Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pkg-config on Windows #16830

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Use pkg-config on Windows #16830

wants to merge 12 commits into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Nov 16, 2024

Just an early POC; see #16752 for some details.

@cmb69 cmb69 linked an issue Nov 16, 2024 that may be closed by this pull request
Use pkg-config on Windows #16752
Open
@cmb69 cmb69 force-pushed the cmb/pkg-config-win branch from 997858d to 7fa105b Compare November 27, 2024 17:46
@cmb69
Copy link
Member Author

cmb69 commented Nov 27, 2024

Rebased on force-pushed to resolve merge conflicts, and added two commits.

cmb69 added 4 commits November 27, 2024 19:36
@cmb69
Add missing libenchant.pc
11fd47a 
Since glib.h is actually not included by ext/enchant, there is no need
to pretend it would depend on glib.
@cmb69
Support curl
81289e8
@cmb69
Support XML extensions
b09becd
@cmb69
Use pkg-config for SETUP_ZLIB_LIB()
f40fd0f
@cmb69
Copy link
Member Author

cmb69 commented Dec 1, 2024

Need to resolve the copying of PDBs (see also #17010); might call copy_dep_pdb_into_build_dir() from PHP_EVAL_LIBLINE().

This was referenced Dec 4, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos Awaiting requested review from nielsdos nielsdos will be requested when the pull request is marked ready for review nielsdos is a code owner

@bukka bukka Awaiting requested review from bukka bukka will be requested when the pull request is marked ready for review bukka is a code owner

@devnexen devnexen Awaiting requested review from devnexen devnexen will be requested when the pull request is marked ready for review devnexen is a code owner

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi will be requested when the pull request is marked ready for review SakiTakamachi is a code owner

@kamil-tekiela kamil-tekiela Awaiting requested review from kamil-tekiela kamil-tekiela will be requested when the pull request is marked ready for review kamil-tekiela is a code owner

@alexdowad alexdowad Awaiting requested review from alexdowad alexdowad will be requested when the pull request is marked ready for review alexdowad is a code owner

@youkidearitai youkidearitai Awaiting requested review from youkidearitai youkidearitai will be requested when the pull request is marked ready for review youkidearitai is a code owner

@Girgias Girgias Awaiting requested review from Girgias Girgias will be requested when the pull request is marked ready for review Girgias is a code owner

@dstogov dstogov Awaiting requested review from dstogov dstogov will be requested when the pull request is marked ready for review dstogov is a code owner

@adoy adoy Awaiting requested review from adoy adoy will be requested when the pull request is marked ready for review adoy is a code owner

@TimWolla TimWolla Awaiting requested review from TimWolla TimWolla will be requested when the pull request is marked ready for review TimWolla is a code owner

Assignees
No one assigned
Labels
Category: Build System Extension: bz2 Extension: curl Extension: dba Extension: dom Extension: enchant Extension: ffi Extension: gd Extension: gettext Extension: gmp Extension: iconv Extension: intl Extension: ldap Extension: libxml Extension: mbstring Extension: mysqlnd Extension: pdo_firebird Extension: pdo_pgsql Extension: pdo_sqlite Extension: pgsql Extension: readline Extension: simplexml Extension: snmp Extension: soap Extension: sodium Extension: sqlite3 Extension: standard Extension: tidy Extension: xml Extension: xmlreader Extension: xmlwriter Extension: xsl Extension: zip Extension: zlib SAPI: apache2handler SAPI: cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use pkg-config on Windows
1 participant
@cmb69