Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config.w32 to allow building on Windows #4

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

cmb69
Copy link
Contributor

@cmb69 cmb69 commented Dec 10, 2024

There is apparently some interest in using php-xpass on Windows, so I gave it a try, and it seems to be working.

Contrary to config.m4, config.w32 uses the "classic" checking for libraries and headers since pkg-config is not (yet) supported on Windows. SHA512 and yescript support are simply assumed to be available in the library (no AC_RUN_IFELSE or similar are supported for the Windows build chain).

@remicollet remicollet merged commit 0653939 into remicollet:master Dec 11, 2024
34 checks passed
@remicollet
Copy link
Owner

Thanks

@remicollet
Copy link
Owner

@cmb69 whould you mind takig care of Windows CI (when libxcrypt will be available there)

Also ping me if you need a new release with Windows compatibililty

@cmb69 cmb69 deleted the cmb/config.w32 branch December 11, 2024 18:40
@cmb69
Copy link
Contributor Author

cmb69 commented Dec 11, 2024

whould you mind takig care of Windows CI (when libxcrypt will be available there)

Submitted #5 for CI, but that won't work. Please ping me in case I forget about that.

Also ping me if you need a new release with Windows compatibililty

The official builds are done by the https://github.com/php/php-windows-builder folks. Let's see if any user requests a build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants