Skip to content

Allow utf-8 filename in phar - fixes 64498 #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Allow utf-8 filename in phar - fixes 64498 #588

wants to merge 13 commits into from

Conversation

Danack
Copy link
Contributor

@Danack Danack commented Feb 13, 2014

Added capturing of utf-8 characters in the RE2C which fixes issue 64498. Also fixes - composer/satis#70

Only the re2c file and the tests have been edited. The C file is generated from the re2c file.

weltling and others added 13 commits February 5, 2014 10:52
* PHP-5.6:
  move the NEWS entry into the right section
* PHP-5.6:
  adapt test to curl 7.35.0 upgrade
* PHP-5.6:
  Fix year
* PHP-5.6:
  more tests for ICU >= 52.1 compat
  fix tests for ICU >= 52.1
* PHP-5.6:
  updated libs_version.txt
  updated libs_version.txt
  update libs_version.txt
@php-pulls
Copy link

Comment on behalf of stas at php.net:

merged

@php-pulls php-pulls closed this Apr 21, 2014
tuxity pushed a commit to cakebox/cakebox that referenced this pull request May 8, 2014
…ent. ref #23

utf 8 characters problem in names should be fixed in php 5.6 with php/php-src#588
@InfoLibre
Copy link

The bug is still here in PHP 5.5.9 :
https://bugs.php.net/bug.php?id=70091&edit=2
david@ordinateur-David ~ $ php --version
PHP 5.5.9-1ubuntu4.11 (cli) (built: Jul 2 2015 15:23:08)
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.5.0, Copyright (c) 1998-2014 Zend Technologies
with Zend OPcache v7.0.3, Copyright (c) 1999-2014, by Zend Technologies

@nikic
Copy link
Member

nikic commented Jul 22, 2015

@petrouchka The current version of PHP 5.5 is 5.5.27. Looking at the tag list in ea4cee9 this was merged in 5.5.13.

@InfoLibre
Copy link

I'm using Linux Mint MATE 17.2 and my version of PHP is 5.5.9
https://secure.php.net/releases/5_5_9.php

david@ordinateur-David ~ $ php --version
PHP 5.5.9-1ubuntu4.11 (cli) (built: Jul 2 2015 15:23:08)

And I stil have the same error for this bug :

Fatal error: Uncaught exception 'BadMethodCallException' with message 'Entry Cliquez ici pour démarrer COMPILIBRE.bat cannot be created: phar error: invalid path "Cliquez ici pour démarrer COMPILIBRE.bat" contains illegal character' in /home/david/Documents/logiciels/COMPILIBRE/git.framasoft.org/COMPILIBRE-source/COMPILIBRE/compilation.php:271 Stack trace: #0 /home/david/Documents/logiciels/COMPILIBRE/git.framasoft.org/COMPILIBRE-source/COMPILIBRE/compilation.php(271): PharData->buildFromDirectory('compilations/1') #1 {main} thrown in /home/david/Documents/logiciels/COMPILIBRE/git.framasoft.org/COMPILIBRE-source/COMPILIBRE/compilation.php on line 271

You can try with using COMPILIBRE : http://www.numopen.fr/installation
or I can send you my PHP script if you need it to see the error.

@nikic
Copy link
Member

nikic commented Jul 22, 2015

@petrouchka You are still getting this error, because you are on an old version of PHP, which does not yet contain this fix. Your version is from February 2014, while this issue was fixed in May 2014. If you want to have this fix, you need to update your PHP installation.

@InfoLibre
Copy link

Indeed. Thank you.

Micdu70 pushed a commit to Micdu70/cakebox that referenced this pull request May 18, 2016
…ent. ref cakebox#23

utf 8 characters problem in names should be fixed in php 5.6 with php/php-src#588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants