[CLI] Stop closing standard streams (v8.1) #8570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morrisonlevi
force-pushed
the
stop-closing-cli-streams-8.1
branch
3 times, most recently
from
fec37e1 to
751bfb8
Compare
cmb69
reviewed
May 17, 2022
morrisonlevi
force-pushed
the
stop-closing-cli-streams-8.1
branch
from
751bfb8 to
0f3486e
Compare
Extensions may (and do) write to stderr in mshutdown and similar. In the best case, with the stderr stream closed, it's just swallowed. However, some libraries will do things like try to detect color, and these will outright fail and cause an error path to be taken.
morrisonlevi
force-pushed
the
stop-closing-cli-streams-8.1
branch
from
0f3486e to
12d1918
Compare
bwoebi
reviewed
May 18, 2022
cmb69
reviewed
May 18, 2022
morrisonlevi
changed the title
arnaud-lb
pushed a commit
to arnaud-lb/php-src
that referenced
this pull request
May 20, 2022
Extensions may (and do) write to stderr in mshutdown and similar. In the best case, with the stderr stream closed, it's just swallowed. However, some libraries will do things like try to detect color, and these will outright fail and cause an error path to be taken.
arnaud-lb
added a commit
to arnaud-lb/php-src
that referenced
this pull request
May 20, 2022
* PHP-8.1: Stop closing stderr and stdout streams (php#8570) Revert "XFAIL tests (phpGH-8588)" XFAIL tests (phpGH-8588) Stop closing stderr and stdout streams (php#8569)
|
Merged in ffd27bd |
dixyes
added a commit
to dixyes/phpmicro
that referenced
this pull request
Jun 16, 2022
dixyes
added a commit
to dixyes/phpmicro
that referenced
this pull request
Jun 16, 2022
dixyes
added a commit
to dixyes/phpmicro
that referenced
this pull request
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extensions may (and do) write to stderr in mshutdown and similar. In
the best case, with the stderr stream closed, it's just swallowed.
However, some libraries will do things like try to detect color, and
these will outright fail and cause an error path to be taken.