Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PHP minimum version to 7.2 #49

Merged
merged 1 commit into from
Nov 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/lint-and-analyse-php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ jobs:
- name: Checkout code
uses: actions/checkout@v4

- name: Set up PHP 7.1
- name: Set up PHP 7.2
uses: shivammathur/setup-php@v2
with:
php-version: 7.1
php-version: 7.2
tools: composer:v2

- name: Validate composer.json and composer.lock
Expand All @@ -34,10 +34,10 @@ jobs:
- name: Checkout code
uses: actions/checkout@v4

- name: Set up PHP 7.1
- name: Set up PHP 7.2
uses: shivammathur/setup-php@v2
with:
php-version: 7.1
php-version: 7.2
tools: composer:v2

- name: Install Composer dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
continue-on-error: ${{ matrix.experimental }}
strategy:
matrix:
php-version: ['7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
php-version: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
extensions: [':apcu, mbstring', 'apcu, mbstring']
os: [ubuntu-latest]
experimental: [false]
Expand Down
2 changes: 1 addition & 1 deletion .scrutinizer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ build:
nodes:
analysis:
environment:
php: 7.1
php: 7.2
dependencies:
before:
- composer install
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## [Unreleased]

* Bump PHP minimum version to 7.2
* Add support for Symfony 7

## [5.3.1] - 2023-08-23

* Add function guards to the global functions (#44)
Expand Down
8 changes: 4 additions & 4 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@
]
},
"require": {
"php": "^7.1 || ^8.0",
"symfony/expression-language": "^4.0 || ^5.0 || ^6.0"
"php": "^7.2 || ^8.0",
"symfony/expression-language": "^5.0 || ^6.0 || ^7.0"
},
"require-dev": {
"phpunit/phpunit": "^7.5 || ^8.5 || ^9.6 || ^10.3",
"phpunit/phpunit": "^8.5 || ^9.6 || ^10.5",
"phpmyadmin/coding-standard": "^3.0.0",
"phpstan/phpstan": "^1.4.6"
"phpstan/phpstan": "^1.12"
},
"autoload": {
"psr-4": {
Expand Down
9 changes: 7 additions & 2 deletions phpstan-baseline.neon
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
parameters:
ignoreErrors:
-
message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#"
message: "#^Offset 'lang' on array\\{0\\: string, lang\\: non\\-falsy\\-string, 1\\: non\\-falsy\\-string, country\\?\\: string, 2\\?\\: string, charset\\?\\: string, 3\\?\\: string, modifier\\?\\: non\\-empty\\-string, \\.\\.\\.\\} on left side of \\?\\? always exists and is not nullable\\.$#"
count: 1
path: src/StringReader.php
path: src/Loader.php

-
message: "#^Cannot cast mixed to int\\.$#"
count: 1
path: src/Translator.php

-
message: "#^Parameter \\#1 \\$str of function ltrim expects string, string\\|false given\\.$#"
count: 1
path: src/Translator.php

-
message: "#^Strict comparison using \\=\\=\\= between non\\-empty\\-array\\<int, string\\> and false will always evaluate to false\\.$#"
count: 1
Expand Down
Loading