Discover repository class from #[Entity] attribute on PHP 8

[ruudk]

By doing it like this, we don't need to instantiate the object manager at all which makes PHPStan run faster and more reliable. Very often I had to manually clear my Symfony cache and re-run PHPStan.

Unfortunately, BetterReflection doesn't support attributes yet so therefore we need to use native ReflectionClass.

See phpstan/phpstan#5863 (reply in thread)

[ruudk]

Hmm, I don't understand why on PHP 8.0 it fails.

[ondrejmirtes]

Please try the nice way via ClassReflection::getNativeReflection() and require phpstan/phpstan: "^1.3" here.

[ondrejmirtes]

The fact that PHPStan reports an error like that is weird and I should look into it, but it might still work correctly. Hard to tell without a test.

[ruudk]

For some reason I cannot install the dependencies for this project anymore:

  Problem 1
    - Root composer.json requires doctrine/mongodb-odm ^1.3 || ^2.1 -> satisfiable by doctrine/mongodb-odm[1.3.0-RC1, ..., 1.3.x-dev, 2.1.0, ..., 2.3.x-dev].
    - doctrine/orm[2.9.1, ..., 2.11.x-dev] require doctrine/common ^3.0.3 -> satisfiable by doctrine/common[3.0.3, ..., 3.2.x-dev].
    - Conclusion: don't install doctrine/common 3.2.0 (conflict analysis result)
    - Root composer.json requires doctrine/orm ^2.9.1 -> satisfiable by doctrine/orm[2.9.1, ..., 2.11.x-dev].

Weird that it just works on CI.

[ondrejmirtes]

Yeah, you need --ignore-platform-reqs if you don't have the mongodb PHP extension installed locally.

[ruudk]

That works, weird that the error doesn't mention ext-mongodb

I don't know how to solve the error on PHP 8. It seems that PHPStan doesn't understand ReflectionAttribute.

[ondrejmirtes]

I really don't know, it works in the playground: https://phpstan.org/r/fa2489cc-dfd7-4a61-8865-c29e83a8a2a6

[ruudk]

\PHPStan\dumpType($this->reflectionProvider->getClass($className));
\PHPStan\dumpType($this->reflectionProvider->getClass($className)->getNativeReflection());
\PHPStan\dumpType($this->reflectionProvider->getClass($className)->getNativeReflection()->getAttributes());

  101    Dumped type: PHPStan\Reflection\ClassReflection
  102    Dumped type: ReflectionClass
  103    Call to an undefined method ReflectionClass::getAttributes().

🤷

[ondrejmirtes]

I know! It's caused by config.platform.php here:

phpstan-doctrine/composer.json

Lines 36 to 41 in 04cace0

	"config": {
	"platform": {
	"php": "7.3.24",
	"ext-mongo": "1.6.16"
	},
	"sort-packages": true

[ruudk]

I removed the php platform and now phpunit fails. Shouldn't PHPunit be installed differently on PHP < 7.3?

I fixed the name of the mongodb extension, as it was wrong.

[ruudk]

Ok, 2 problems left:

1. How to prevent Call to an undefined method ReflectionClass::getAttributes(). on < PHP 8? My previous method_exists complains on PHP 8 that it's always true

2. PHP 7.1 becomes a problem as it requires https://packagist.org/packages/doctrine/mongodb-odm#1.3.0 that needs a deprecated mongo extension. Should we just install with --ignore-platform-req=php on PHP 7.1? It's a bit like it was, with the fake 7.3 in composer config platform.

[ruudk]

Oke, so the only problem left seems to be a bug in PHPStan, am I right?

https://phpstan.org/r/a34ea8cd-2986-4bbf-82e2-a1041cb4a6de

If so, I can report it on phpstan/phpstan

[ruudk]

@ondrejmirtes I hoped that PHPStan 1.3 would solve the problem with attributes, as the release notes mention this:

This brings plenty of bugfixes, for example PHP 8.0 Attributes can now be read in static reflection context

but I still cannot solve the problem.

Any idea how to proceed?

[ondrejmirtes]

What PHPStan 1.3 fixed was an internal PHP error when accessing ClassReflection::getNativeReflection()->getAttributes() in some cases.

Are you trying to solve the problem on PHP 7.x from this example? https://phpstan.org/r/a34ea8cd-2986-4bbf-82e2-a1041cb4a6de This is usually solved by having different PHPStan configs for different PHP versions (when a project is analysed on different PHP cersions).

One notable example is PHPStan itself: https://github.com/phpstan/phpstan-src/blob/master/build/ignore-by-php-version.neon.php

This file is included in phpstan.neon: https://github.com/phpstan/phpstan-src/blob/b614f4af90b26e24d653b9d11a27679ee9b459ad/build/phpstan.neon#L10

[ruudk]

@ondrejmirtes It worked 🎉 Ready for review.

[ruudk]

While writing some tests, I notice that $this->reflectionProvider->hasClass($className) returns false, and therefore it skips my code. Isn't it possible to reflect unknown classes?

[ondrejmirtes]

Looks like I'm gonna solve this in a general way for all the rules :) #253

[ruudk]

🥳🥳🥳🥳🥳 thank you