Test all jobs on PHP 8.1 #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruudk
force-pushed
the
patch-2
branch
7 times, most recently
from
4f3c89a to
52c22a1
Compare
|
@ondrejmirtes This is ready. Had to conflict with older version of |
|
While testing this in #238 I think we can better handle this differently. Will update this PR. |
ruudk
force-pushed
the
patch-2
branch
3 times, most recently
from
4218971 to
40576ea
Compare
|
@ondrejmirtes Ok, I think this is better. Only 1 problem left, on PHP 7.1 an older version of - "message": "Parameter #1 $className of method Doctrine\\Persistence\\ObjectManager::getRepository() expects class-string<nonexistentClass>, string given.",\n
+ "message": "Parameter #1 $className of method Doctrine\\ORM\\EntityManagerInterface::getRepository() expects class-string<nonexistentClass>, string given.",Does the |
ruudk
force-pushed
the
patch-2
branch
3 times, most recently
from
6a60aa0 to
a5d23a1
Compare
|
It's finally green. What a hassle. Hope you agree with the changes :) |
|
@ondrejmirtes can this be merged? |
Needed for Composer 2.2.0 (found with 2.2.0-RC1)
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.