[WIP] Use real object managers #40
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods `EntityManagerInterface#getReference()` and `EntityManagerInterface#getPartialReference()` have nullable return. That's properly documented for `getReference()` but had to be fixed for `getPartialReference()`.
So that things would be compatible with both ORM and ODM.
With the necessary dependencies on Travis-CI to ensure the build will run properly. Following the same approach as https://github.com/doctrine/mongodb/blob/1.6.3/.travis.yml#L61 (for PHP 7+ installation).
Based on the class metadata we can easily fetch data from any configuration format.
lcobucci
force-pushed
the
poc-use-real-object-managers
branch
from
dcb011e to
b7c93f3
Compare
|
any update to this @lcobucci |
|
It’s waiting for my review, sorry for the delay.
On Wed, 24 Oct 2018 at 09:23, Alexander Schranz ***@***.***> wrote:
any update to this @lcobucci <https://github.com/lcobucci>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGZuMHrr-btE8YMfT_R0KFLoNyp5LHmks5uoBV-gaJpZM4WCtMv>
.
--
Ondřej Mirtes
|
|
ping @ondrejmirtes ;-) |
|
I'm really looking forward to this but we have to solve #39 first. |
mcfedr
reviewed
Feb 12, 2019
|
|
||
| parameters: | ||
| doctrine: | ||
| objectManagerLoader: tests/DoctrineIntegration/ORM/entity-manager.php |
Merged
|
Superceded by #49. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this implementation we're able to use the class metadata to retrieve repository information, given the user provides the entity/document manager instance.
Depends on #39