Use real object managers

[mcfedr]

#40, rebased on #48

as in the original, with this implementation we're able to use the class metadata to retrieve repository information, given the user provides the entity/document manager instance.

Additionally, will use default repositoryClass when no objectManagerLoader is provided.

[ondrejmirtes]

I'll look into this ASAP.

What's cool that it will allow more precise info for purposes like magic findBy methods on repositories (like #35) and gasp static DQL validation!

[mcfedr]

Not so sure about 0b810f7 - is the good approach for this problem?

[ondrejmirtes]

It's not needed - you can ask instanceof $string.

[mcfedr]

It's not needed - you can ask instanceof $string.

In 1cc26d1, But phpstan doesn't get it, so still need to alias $metadata and use @var... its slightly better, and you cannot instance 'Literal' so its not very pretty...

Without the alias, I get

------ ----------------------------------------------------------------------------------------------------------------
  Line   src/Type/Doctrine/ObjectMetadataResolver.php
 ------ ----------------------------------------------------------------------------------------------------------------
  52     Access to an undefined property Doctrine\Common\Persistence\Mapping\ClassMetadata::$customRepositoryClassName.
  57     Access to an undefined property Doctrine\Common\Persistence\Mapping\ClassMetadata::$customRepositoryClassName.
 ------ ----------------------------------------------------------------------------------------------------------------

[lcobucci]

@mcfedr thanks for picking things up and continuing the work 👍 Way too many things got in my way and I couldn't continue.

[mcfedr]

@mcfedr thanks for picking things up and continuing the work 👍 Way too many things got in my way and I couldn't continue.

yes, these things happen, I had some time and saw stuff so nearly ready that I'm excited to use. Hopefully we can finish these things off asap and get a new release out.

[mcfedr]

On that note, I must say thanks @ondrejmirtes for being available and ready to review this and the other PRs today.

[ondrejmirtes]

It’s going to be awesome 😊

On Tue, 12 Feb 2019 at 21:49, Fred Cox ***@***.***> wrote: On that note, I must say thanks @ondrejmirtes <https://github.com/ondrejmirtes> for being available and ready to review this and the other PRs today. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#49 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGZuBzMe27a8kHDJQHPJJtx8Ri7icPnks5vMyjZgaJpZM4a2iIY> .

-- Ondřej Mirtes

[ondrejmirtes]

Thank you! 👍

[ondrejmirtes]

This is mind-blowing: 0947875