Add integration tests for ODM features #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis job has failed because of some travis issue, but you can see in the php 7.1 job that it passes. |
|
Please rebase on top of master, it conflicts now. |
With the necessary dependencies on Travis-CI to ensure the build will run properly. Following the same approach as https://github.com/doctrine/mongodb/blob/1.6.3/.travis.yml#L61 (for PHP 7+ installation).
mcfedr
force-pushed
the
add-integration-tests-for-odm-features
branch
from
c7fd1f9 to
6f83452
Compare
ondrejmirtes
requested changes
Feb 12, 2019
| }, | ||
| "config": { | ||
| "platform": { | ||
| "ext-mongo": "1.6.16" |
There was a problem hiding this comment.
doctrine/mongodb-odm requires ext-mongo, this tells composer that its installed, even though it isnt, and allows odm to be installed
There was a problem hiding this comment.
The other option is to run composer install with --ignore-platform-reqs, if you think thats better @ondrejmirtes ?
Merged
ondrejmirtes
approved these changes
Feb 12, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #39 but without extra composer deps
Had to leave 'config.mongodb' in composer json so that it would allow installing doctrine-odm