Skip to content

Commit

Permalink
fix(API): allow nullable value for job's due_date (#534)
Browse files Browse the repository at this point in the history
* Make due_date argument nullable

* Make due_date argument nullable in show and update actions

* Add updated compiled.json file

* Testing Java CI build with dependency added to pom file

* Testing Java CI build with update made to ApiClient.mustache

* Added nullable dependency in gradle

* Added specs

* Corrected Assertion

* Corrected Assertion

* Corrected Assertion

* Corrected Assertion

* Clean up gitignore
  • Loading branch information
hahmed-dev committed Feb 5, 2024
1 parent 4af2c66 commit 38b51b5
Show file tree
Hide file tree
Showing 7 changed files with 74 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,4 @@ doc/*.js
tmp/
node_modules/
.DS_Store
clients/cli/README.md
clients/cli/README.md
63 changes: 63 additions & 0 deletions clients/go/test/api_jobs_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions doc/compiled.json
Original file line number Diff line number Diff line change
Expand Up @@ -3026,7 +3026,8 @@
},
"due_date": {
"type": "string",
"format": "date-time"
"format": "date-time",
"nullable": true
},
"state": {
"type": "string"
Expand Down Expand Up @@ -9505,7 +9506,8 @@
"description": "Date the job should be finished",
"type": "string",
"format": "date-time",
"example": "2017-08-15"
"example": "2017-08-15",
"nullable": true
},
"ticket_url": {
"description": "URL to a ticket for this job (e.g. Jira, Trello)",
Expand Down Expand Up @@ -9804,7 +9806,8 @@
"description": "Date the job should be finished",
"type": "string",
"format": "date-time",
"example": "2017-08-15"
"example": "2017-08-15",
"nullable": true
},
"ticket_url": {
"description": "URL to a ticket for this job (e.g. Jira, Trello)",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ dependencies {
implementation 'com.squareup.okhttp3:logging-interceptor:3.14.7'
implementation 'com.google.code.gson:gson:2.8.6'
implementation 'io.gsonfire:gson-fire:1.8.4'
implementation 'org.openapitools:jackson-databind-nullable:0.2.1'
{{#hasOAuthMethods}}
implementation group: 'org.apache.oltu.oauth2', name: 'org.apache.oltu.oauth2.client', version: '1.0.1'
{{/hasOAuthMethods}}
Expand Down
1 change: 1 addition & 0 deletions paths/jobs/create.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ requestBody:
type: string
format: date-time
example: '2017-08-15'
nullable: true
ticket_url:
description: URL to a ticket for this job (e.g. Jira, Trello)
type: string
Expand Down
1 change: 1 addition & 0 deletions paths/jobs/update.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ requestBody:
type: string
format: date-time
example: '2017-08-15'
nullable: true
ticket_url:
description: URL to a ticket for this job (e.g. Jira, Trello)
type: string
Expand Down
1 change: 1 addition & 0 deletions schemas/job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ job:
due_date:
type: string
format: date-time
nullable: true
state:
type: string
ticket_url:
Expand Down

0 comments on commit 38b51b5

Please sign in to comment.