fix(API): allow nullable value for job's due_date #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hahmed-dev
changed the title
hahmed-dev
commented
Feb 2, 2024
| @@ -142,6 +142,7 @@ dependencies { | |||
| implementation 'com.squareup.okhttp3:logging-interceptor:3.14.7' | |||
| implementation 'com.google.code.gson:gson:2.8.6' | |||
| implementation 'io.gsonfire:gson-fire:1.8.4' | |||
| implementation 'org.openapitools:jackson-databind-nullable:0.2.1' | |||
There was a problem hiding this comment.
The reason for adding this line was failure encountered in Java tests regarding package resolution.
jablan
approved these changes
Feb 5, 2024
|
|
||
| // Access the values from the JSON payload | ||
| assert.Equal(t, requestBody["name"], "createjobactionb1") | ||
| assert.Equal(t, requestBody["due_date"], nil) |
There was a problem hiding this comment.
I presume this assertion fails when the change in /path/jobs is reverted?
There was a problem hiding this comment.
Yes, let me add some screenshot to description to make it clear. :)
There was a problem hiding this comment.
@jablan when I remove nullable from create.yaml
There was a problem hiding this comment.
thanks, I wasn't really doubting :)
|
minor comment: I wouldn't title this |
hahmed-dev
changed the title
This was referenced Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
When creating a job from CLI and not providing
due_datewas adding a dummy due_date, which in fact was Go Lang adding a zero value to an attributedue_dateof Time type if no value is provided.This PR updates the schema to allow
nullablevalues againstdue_dateforcreate,updaterequests as well as when fetching the job.Relevant Ticket: https://phrase.atlassian.net/browse/TSI-2297