feat(API): add Custom Metadata endpoints #474
Conversation
anthonyshchang
requested review from
jablan,
ildarsafin,
forelabs,
BlumMichael and
malvarezphrase
anthonyshchang
changed the title
| @@ -10,7 +10,7 @@ tags: | |||
| parameters: | |||
| - "$ref": "../../parameters.yaml#/X-PhraseApp-OTP" | |||
| - "$ref": "../../parameters.yaml#/account_id" | |||
| - "$ref": "../../parameters.yaml#/data_type" | |||
| - "$ref": "../../parameters.yaml#/custom_metadata_data_type" | |||
There was a problem hiding this comment.
I'm curious, why is there a data_type parameter? is it for filtering properties only for the given type? what was the use case for adding this?
in phrase code, I can see there's also q parameter (which makes more sense IMO), why has it been left out?
There was a problem hiding this comment.
is it for filtering properties only for the given type?
yep, believe so
what was the use case for adding this?
perhaps a convenience method of getting all date-related properties for mass update?
…CM schema in translation key response (#480) * add CM to create/update keys * Add custom metadata object on CM get key * Add more description for update --------- Co-authored-by: Ildar Safin <knock@ildarsafin.tech>
|
Tested the creation of key and response body: We are getting CM inside: 
|
parameters.yaml
Outdated
| @@ -35,9 +35,18 @@ custom_metadata_data_type: | |||
| in: query | |||
| name: data_type | |||
| description: Data Type of Custom Metadata Property | |||
| required: false | |||
| required: true | |||
There was a problem hiding this comment.
by doing this, it is also mandatory in the index call, right? I'm pretty sure we don't want that.
There was a problem hiding this comment.
this is actually confusing since it's rendered also in create/update CM pages and it's shown as not required which is not true
There was a problem hiding this comment.
yeah, I'm afraid it can't be reused as a single reference then.
There was a problem hiding this comment.
wait, perhaps it can be specified using required array
There was a problem hiding this comment.
nah, forget it. you can't reuse the same reference.
jablan
changed the title
ildarsafin
removed
the
DONT MERGE
Screen.Recording.2023-11-30.at.15.02.48.mov
DONT MERGE
DONT MERGE UNTIL FEATURE TOGGLE IS REMOVED!
Ticket
https://phrase.atlassian.net/browse/TSS-2511