feat: update translation key create/update with custom metadata. Add CM schema in translation key response #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyshchang
requested review from
ildarsafin,
malvarezphrase and
BlumMichael
malvarezphrase
approved these changes
Dec 11, 2023
jablan
requested changes
Dec 11, 2023
|
@forelabs we can merge this pr even today if possible since its going to be merged to TSS-1890-rest-api-index branch |
ildarsafin
changed the title
ildarsafin
changed the title
|
Will have a look in a second |
forelabs
approved these changes
Dec 12, 2023
ildarsafin
removed
the
DONT MERGE
jablan
approved these changes
Dec 12, 2023
ildarsafin
deleted the
TSS-2504-update-api-docs-for-translation-key-custom-metadata
branch
ildarsafin
added a commit
that referenced
this pull request
Dec 13, 2023
* register Custom Metadata Labels to main yml * add custom metadata schema * add custom metadata index path * add enum for data_type * specify 2.9 cli version * generalize custom metadata tag * correct path for index route * update path * update compiled json * align Custom Metadata tag usage * add project ids param to labels index * add sort and order to metadata label index * update url params example * make summary and description more clear and concise * add endpoint availability notice * remove account ref from schema * add projects to custom metadata label schema * update label -> property * rename CM paths folder * fix parameter definitions * feat(api): Add show API endpoint for custom_metadata_labels (#359) * add paths for custom metadata show * make summary and description more clear and concise * fix path with namespace * change from label to property for consistency * remove unused branch param --------- Co-authored-by: Matias Alvarez <matias.alvarez@phrase.com> * feat: add CM api update (#475) * add name and description * add create api doc for CM properties (#476) * feat: add delete CM property doc (#477) * add delete api doc for CM properties * rename data type to custom metadata data type * nest create under collection * update routes to use properties instead of labels * fix project_id example * update path CM route naming * feat: update translation key create/update with custom metadata. Add CM schema in translation key response (#480) * add CM to create/update keys * Add custom metadata object on CM get key * Add more description for update --------- Co-authored-by: Ildar Safin <knock@ildarsafin.tech> * Make create CM example to be working with CURL * Make the data_type field to be not required * extract custom metadata data type schema --------- Co-authored-by: Matias Alvarez <matias.alvarez@phrase.com> Co-authored-by: Ildar Safin <knock@ildarsafin.tech> Co-authored-by: Mladen Jablanovic <mladen.jablanovic@phrase.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update translation key create/update with custom metadata. Also. add CM in translation key schema response
response CM in translation key
Update/Create CM on translation key
Screen.Recording.2023-12-07.at.10.34.10.mov
Ticket
https://phrase.atlassian.net/browse/TSS-2504