Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Add show API endpoint for custom_metadata_labels #359

Merged
merged 10 commits into from
Dec 5, 2023

Conversation

anthonyshchang
Copy link
Contributor

@anthonyshchang anthonyshchang commented Jul 11, 2023

Screen.Recording.2023-11-30.at.15.30.45.mov

DONT MERGE

DONT MERGE UNTIL FEATURE TOGGLE IS REMOVED!

Ticket

https://phrase.atlassian.net/browse/TSS-2512

@anthonyshchang anthonyshchang changed the base branch from master to TSS-1890-rest-api-index July 11, 2023 11:47
@anthonyshchang anthonyshchang added the DONT MERGE indicates that the PR should not (yet) be merged label Jul 13, 2023
@anthonyshchang anthonyshchang marked this pull request as ready for review November 30, 2023 14:32
@anthonyshchang anthonyshchang merged commit b56d328 into TSS-1890-rest-api-index Dec 5, 2023
12 checks passed
@anthonyshchang anthonyshchang deleted the TSS-1891-rest-api-show branch December 5, 2023 15:45
ildarsafin added a commit that referenced this pull request Dec 13, 2023
* register Custom Metadata Labels to main yml

* add custom metadata schema

* add custom metadata index path

* add enum for data_type

* specify 2.9 cli version

* generalize custom metadata tag

* correct path for index route

* update path

* update compiled json

* align Custom Metadata tag usage

* add project ids param to labels index

* add sort and order to metadata label index

* update url params example

* make summary and description more clear and concise

* add endpoint availability notice

* remove account ref from schema

* add projects to custom metadata label schema

* update label -> property

* rename CM paths folder

* fix parameter definitions

* feat(api): Add show API endpoint for custom_metadata_labels (#359)

* add paths for custom metadata show

* make summary and description more clear and concise

* fix path with namespace

* change from label to property for consistency

* remove unused branch param

---------

Co-authored-by: Matias Alvarez <matias.alvarez@phrase.com>

* feat: add CM api update (#475)

* add name and description

* add create api doc for CM properties (#476)

* feat:  add delete CM property doc (#477)

* add delete api doc for CM properties

* rename data type to custom metadata data type

* nest create under collection

* update routes to use properties instead of labels

* fix project_id example

* update path CM route naming

* feat: update translation key create/update with custom metadata. Add CM schema in translation key response (#480)

* add CM to create/update keys

* Add custom metadata object on CM get key

* Add more description for update

---------

Co-authored-by: Ildar Safin <knock@ildarsafin.tech>

* Make create CM example to be working with CURL

* Make the data_type field to be not required

* extract custom metadata data type schema

---------

Co-authored-by: Matias Alvarez <matias.alvarez@phrase.com>
Co-authored-by: Ildar Safin <knock@ildarsafin.tech>
Co-authored-by: Mladen Jablanovic <mladen.jablanovic@phrase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DONT MERGE indicates that the PR should not (yet) be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants