Fix caddr_t compilation errors
#112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasilva
changed the title
caddr_t compilation errors
phillipstanleymarbell
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two files in the Freescale SDK make use of
caddr_twhich is a presently unused data type. This StackExchange discussion sheds more light into it and instructs all references of this type to be replaced withvoid *, which is what I have done in this PR.I'm not too sure why I got this error and some of my colleagues didn't, I can only assume it is because of my development platform: macOS Ventura with the latest ARM GNU toolchain downloaded 1 day ago: 12.2 rel-1.
I'm not even sure if this is the right fix or if this breaks something, but I couldn't think of any alternatives. The function using this
_sbrkitself confuses me as it is defined twice in two files with one conditionally existing on a couple of#defines that I don't have the time to look for. Might this be function overloading?The firmware successfully compiled for me after this, so...