fix: move close button to top of share modal for better UX#192
Merged
mattqdev merged 2 commits intophysicshub:mainfrom Feb 18, 2026
Merged
fix: move close button to top of share modal for better UX#192mattqdev merged 2 commits intophysicshub:mainfrom
mattqdev merged 2 commits intophysicshub:mainfrom
Conversation
Contributor
Author
|
Hi, I’ve implemented the requested changes and attached screenshots for reference. |
Owner
|
Hey, sorry for late reply, your PR is fine and almost ready to be merged. Unfortunatly while trying to delete the package-lock.json from the PR, I accidentally deleted it entirely. Can you please update the PR so that these changes aren't recorded? After this I'll merge your PR |
02d9ebd to
e52572e
Compare
Contributor
Author
|
I’ve restored the package-lock.json file and updated the PR. |
Collaborator
|
Thank you so much for this fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📘 Pull Request Template – PhysicsHub
Thank you for contributing to PhysicsHub!
Please complete the sections below to help us review your pull request efficiently.
🔍 Description
This PR improves the usability of the share modal by moving the close button to the top of the modal container. Previously, the close button was placed after the social media icons, requiring users to scroll before being able to dismiss the modal.
Changes Made
Benefits
Closes #191
✅ Checklist
Before requesting a review, please ensure that you have:
npm run dev)🎨 Visual Changes (if UI-related)
Before
After
📂 Type of Change
🧩 Additional Notes for Reviewers