Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for txt files #41

Closed
3 of 6 tasks
smoia opened this issue Nov 26, 2019 · 7 comments
Closed
3 of 6 tasks

Add support for txt files #41

smoia opened this issue Nov 26, 2019 · 7 comments
Labels
Enhancement New feature or request Help wanted Extra attention is needed
Milestone
phys2bids first n...

Comments

@smoia
Copy link
Member

smoia commented Nov 26, 2019 •
edited by vinferrer
Loading

With the new code, txt is not supported at the moment.

EDIT: txt is partially supported.
The possible txt formats are (tick what's covered):

  • LabChart, with header
  • AcqKnowledge, with header
  • LabChart, without header
  • AcqKnowledge, without header
  • LabChart, with header and comment
  • ...
@smoia smoia added Enhancement New feature or request Help wanted Extra attention is needed labels Nov 26, 2019
@smoia smoia added this to the phys2bids 1.0.0 milestone Nov 26, 2019
@smoia smoia mentioned this issue Nov 28, 2019
Closed
@eurunuela
Copy link
Collaborator

I believe #54 closed this issue.

@smoia
Copy link
Member Author

smoia commented Dec 2, 2019

No, this is a general .txt support - #54 addressed #48 .
This issue is still open untill we support different types of .txt

@smoia smoia reopened this Dec 2, 2019
@eurunuela
Copy link
Collaborator

Oh okay. Perfect!

@vinferrer
Copy link
Collaborator

Do we have other txt files that are not in labchart format?

@smoia
Copy link
Member Author

smoia commented Dec 2, 2019 •
edited
Loading

We do!
Starting from this one.
It's acqknowledge!

@vinferrer
Copy link
Collaborator

Hey guys so I am starting to work on others txt formats and refractoring txt.py so there is a reading function for each txt format, so I am assuming AcqKnowledge files in txt format have to be treated here. Any oposition to this?

@vinferrer vinferrer reopened this Dec 19, 2019
@vinferrer vinferrer mentioned this issue Feb 5, 2020
Merged
@smoia
Copy link
Member Author

smoia commented Feb 13, 2020

As we said we'll not cover txt files without header before our first full release, I'm going to open an issue specifically for that and close this one.

@smoia smoia closed this as completed Feb 13, 2020
@smoia smoia mentioned this issue Feb 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request Help wanted Extra attention is needed
Projects
None yet
Milestone
phys2bids first non-beta
Development

No branches or pull requests
3 participants
@eurunuela @smoia @vinferrer