-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding txt support for labchart #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great job and a great enhancement!
I can't wait to see it merged in the master, you just need to add a couple of things (and check out English sentences)
delete unecessary import Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>
eliminate comment of file dir Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>
add unit to the f string Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>
unnecesary f-string Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>
I have done the changes, review the if you want and accept them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And another one!
close #48
Hi guys, I implemented txt support for labchart files, could you review my code? no rush.
Cheers,
Vicente