Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding txt support for labchart #54

Merged
merged 18 commits into from
Dec 2, 2019
Merged

Adding txt support for labchart #54

merged 18 commits into from
Dec 2, 2019

Conversation

vinferrer
Copy link
Collaborator

close #48

Hi guys, I implemented txt support for labchart files, could you review my code? no rush.

Cheers,
Vicente

Copy link
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great job and a great enhancement!
I can't wait to see it merged in the master, you just need to add a couple of things (and check out English sentences)

phys2bids/interfaces/txt.py Outdated Show resolved Hide resolved
phys2bids/interfaces/txt.py Outdated Show resolved Hide resolved
phys2bids/interfaces/txt.py Outdated Show resolved Hide resolved
phys2bids/interfaces/txt.py Show resolved Hide resolved
phys2bids/interfaces/txt.py Outdated Show resolved Hide resolved
phys2bids/interfaces/txt.py Outdated Show resolved Hide resolved
phys2bids/interfaces/txt.py Outdated Show resolved Hide resolved
phys2bids/interfaces/txt.py Outdated Show resolved Hide resolved
vinferrer and others added 8 commits November 30, 2019 09:39

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
delete unecessary import

Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
eliminate comment of file dir

Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
add unit to the f string

Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
unnecesary f-string

Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>
@vinferrer
Copy link
Collaborator Author

I have done the changes, review the if you want and accept them

@smoia smoia added the Enhancement New feature or request label Dec 1, 2019
Copy link
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny comment!

phys2bids/interfaces/txt.py Show resolved Hide resolved
Copy link
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And another one!

phys2bids/interfaces/txt.py Outdated Show resolved Hide resolved
@smoia smoia added the Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) label Dec 2, 2019
@smoia smoia merged commit 8a7ae2b into physiopy:master Dec 2, 2019
@eurunuela eurunuela mentioned this pull request Dec 2, 2019
6 tasks
@vinferrer vinferrer deleted the txt branch December 7, 2019 08:01
@smoia smoia added the released This issue/pull request has been released. label Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add txt support
2 participants