Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds logger functionality #134

Merged
merged 20 commits into from
Feb 15, 2020
Merged

Adds logger functionality #134

merged 20 commits into from
Feb 15, 2020

Conversation

eurunuela
Copy link
Collaborator

@eurunuela eurunuela commented Jan 25, 2020 •
edited
Loading

Closes #28. Partially closes #142 .

Proposed Changes

  • Adds logger and log file

@eurunuela eurunuela added the Enhancement New feature or request label Jan 25, 2020
@eurunuela eurunuela added this to the phys2bids first non-beta milestone Jan 25, 2020
@eurunuela eurunuela requested a review from smoia January 25, 2020 10:26
@eurunuela eurunuela self-assigned this Jan 25, 2020
@eurunuela eurunuela marked this pull request as ready for review February 7, 2020 18:01
@eurunuela
Copy link
Collaborator Author

I believe this should cover all the logger statements. Please check I've not missed any.

@smoia
Copy link
Member

smoia commented Feb 7, 2020

Can I ask someone else to review it? I think you need two reviewers anyway.
I have a couple of suggestions that i can send as comments anyway later on!

@smoia smoia requested review from rmarkello and vinferrer February 7, 2020 18:44
@codecov
Copy link

codecov bot commented Feb 11, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a2c9aa9). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #134   +/-   ##
=========================================
  Coverage          ?   63.46%           
=========================================
  Files             ?        7           
  Lines             ?      531           
  Branches          ?        0           
=========================================
  Hits              ?      337           
  Misses            ?      194           
  Partials          ?        0
Impacted Files Coverage Δ
phys2bids/cli/run.py 17.85% <ø> (ø)
phys2bids/interfaces/txt.py 95.62% <100%> (ø)

vinferrer
vinferrer approved these changes Feb 11, 2020
View reviewed changes
Copy link
Collaborator

@vinferrer vinferrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that my tests are working again, all good by my part. easy review

smoia
smoia requested changes Feb 11, 2020
View reviewed changes
Copy link
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things to change, but this looks solid!

phys2bids/interfaces/txt.py Outdated Show resolved Hide resolved
phys2bids/physio_obj.py Outdated Show resolved Hide resolved
phys2bids/physio_obj.py Outdated Show resolved Hide resolved
phys2bids/physio_obj.py Outdated Show resolved Hide resolved
phys2bids/utils.py Show resolved Hide resolved
eurunuela and others added 4 commits February 11, 2020 16:43
@eurunuela
Update phys2bids/interfaces/txt.py
b9536cc 
Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>
@eurunuela
Update phys2bids/physio_obj.py
dcbed72 
Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>
@eurunuela
Update phys2bids/physio_obj.py
aeb4cc4 
Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>
@eurunuela
Assess PR review comments and fix linting errors
e7cf602
@eurunuela eurunuela requested a review from smoia February 11, 2020 18:48
@eurunuela
Copy link
Collaborator Author

Removing the raise statements made the tests fail. Will work on that.

@eurunuela
Copy link
Collaborator Author

After fixing all the mess, it's ready to be reviewed again. I opted to not log the errors at the moment. We could add this feature in the future anyway as it is not that critical imo.

@vinferrer
Copy link
Collaborator

oh yes, there is a conflict, damm

@smoia
Copy link
Member

smoia commented Feb 13, 2020

And we miss tests!

@eurunuela
Copy link
Collaborator Author

I'll take care of it!

@eurunuela
Copy link
Collaborator Author

Decided I'll work on the test on a different PR.

@eurunuela eurunuela mentioned this pull request Feb 14, 2020
Closed
@eurunuela
Copy link
Collaborator Author

Okay, apparently the merging conflicts were not that clear. @vinferrer could you please update the test_text.py file to what it should be? You can do it directly in this PR.

@eurunuela eurunuela merged commit e1e63c0 into physiopy:master Feb 15, 2020
@eurunuela eurunuela deleted the add/logger branch February 15, 2020 09:31
@allcontributors
Copy link
Contributor

@smoia

We had trouble processing your request. Please try again later.

3 similar comments
@allcontributors
Copy link
Contributor

@smoia

We had trouble processing your request. Please try again later.

@allcontributors
Copy link
Contributor

@smoia

We had trouble processing your request. Please try again later.

@allcontributors
Copy link
Contributor

@smoia

We had trouble processing your request. Please try again later.

@smoia
Copy link
Member

smoia commented Feb 15, 2020

Ok, doing it myself, got it. Don't be cranky you little bot.

@allcontributors
Copy link
Contributor

@smoia

We had trouble processing your request. Please try again later.

4 similar comments
@allcontributors
Copy link
Contributor

@smoia

We had trouble processing your request. Please try again later.

@allcontributors
Copy link
Contributor

@smoia

We had trouble processing your request. Please try again later.

@allcontributors
Copy link
Contributor

@smoia

We had trouble processing your request. Please try again later.

@allcontributors
Copy link
Contributor

@smoia

We had trouble processing your request. Please try again later.

@smoia smoia mentioned this pull request Feb 15, 2020
Closed
@eurunuela eurunuela changed the title Adds logger Adds logger functionality Mar 27, 2020
@eurunuela eurunuela added the Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) label Mar 27, 2020
@eurunuela
Copy link
Collaborator Author

@smoia, regarding the automatic release thing, should this PR have both the enhancement and minormod labels? My guess is we can have more than one label in our PRs.

@smoia
Copy link
Member

smoia commented Mar 27, 2020 •
edited
Loading

Yes, you can have both Minormod and enhancement, but mainly because only Minormod will trigger auto, and both labels indicate an increase of version 0.+1.0.
You can refer to the contributor guidelines in the Auto PR (#181) to better understand the use of labels!

@smoia smoia mentioned this pull request Mar 27, 2020
Merged
2 tasks
@smoia smoia added the released This issue/pull request has been released. label Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinferrer vinferrer vinferrer approved these changes

@smoia smoia smoia approved these changes

@rmarkello rmarkello Awaiting requested review from rmarkello

Assignees

@eurunuela eurunuela

Labels
Enhancement New feature or request Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) released This issue/pull request has been released.
Projects
None yet
Milestone
phys2bids first non-beta
Development

Successfully merging this pull request may close these issues.

Typos (+ small code suggestion) Add logger
3 participants
@eurunuela @smoia @vinferrer