Solve reading problem: When separating txt file in header an channels, put number of samples in the header instead of the channel_list #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very tiny change, once the test pass this is ready for review @smoia |
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
+ Coverage 65.91% 66.04% +0.12%
==========================================
Files 7 7
Lines 531 533 +2
==========================================
+ Hits 350 352 +2
Misses 181 181 |
smoia
approved these changes
Feb 19, 2020
smoia
added
BugFIX
vinferrer
changed the title
vinferrer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes # Sampling number was being saved in channel_list, now it is saved in the header
Proposed Changes