[REF,ENH] Makes phys2bids a Python package #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To conform to expected format of traditional Python packages. Also made some minor changes to fix linting, etc.
Using either `python setup.py install` or `pip install .`
Allow importing from either file or one of default names
Temporarily until we can extract the relevant pieces and move the workflow to `phys2bids.cli.run`
Tried to recreate full filepath to provided file inside of -outdir
For start of testing!
No tests yet though :(
rmarkello
changed the title
smoia
requested changes
Nov 12, 2019
Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>
Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>
Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>
Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>
Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>
Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>
Co-Authored-By: Stefano Moia <s.moia@bcbl.eu>
smoia
added
the
Majormod
smoia
approved these changes
Nov 12, 2019
rmarkello
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11, begins to address #12.
Major reorganization that converts the single (or two?) scripts into an importable, installable Python package.