Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pi-hole FTL v5.13 #1272

Merged
merged 34 commits into from
Jan 5, 2022
Merged

Pi-hole FTL v5.13 #1272

merged 34 commits into from
Jan 5, 2022

Commits on Dec 24, 2021

  1. Add human-readable table output mode

    Signed-off-by: DL6ER <dl6er@dl6er.de>
    DL6ER committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    4366239 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2021

  1. Generalise --dhcp-relay.

    Sending via broadcast/multicast is now supported for both
    IPv4 and IPv6 and the configuration syntax made
    easier (but backwards compatible).
    
    Signed-off-by: DL6ER <dl6er@dl6er.de>
    simonkelley authored and DL6ER committed Dec 25, 2021
    Configuration menu
    Copy the full SHA
    eb9cf5b View commit details
    Browse the repository at this point in the history
  2. Fix rare "Internal error in cache" messages.

    Fix error created in 1ce1c6beae9f683bec54cba4c0d375f85b209b95
    
    Many thanks to Hartmut Birr for finding the bug and bisecting to
    the guilty commit.
    
    The breaking commit creates cache entries which have F_NXDOMAIN
    set but none of F_IPV4, F_IPV6 or F_SRV. If cache_scan_free() is called
    to delete such an entry it will fail to do so.
    
    If the cache has no free slots and the least-recently-used slot is such
    an entry, then a new insertion will attempt to make space by calling
    cache_scan_free(), which will fail when it should be impossible and
    trigger the internal error.
    
    Signed-off-by: DL6ER <dl6er@dl6er.de>
    simonkelley authored and DL6ER committed Dec 25, 2021
    Configuration menu
    Copy the full SHA
    c7e647e View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2021

  1. Christmas is not Easter

    Signed-off-by: DL6ER <dl6er@dl6er.de>
    DL6ER committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    db153cc View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1262 from pi-hole/new/human_readable_tables

    Add human-readable table output mode
    DL6ER authored Dec 26, 2021
    Configuration menu
    Copy the full SHA
    106ef8c View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2021

  1. Return DNS port on ">dns-port" telnet command

    Signed-off-by: DL6ER <dl6er@dl6er.de>
    DL6ER committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    6ecc1cf View commit details
    Browse the repository at this point in the history
  2. Test: API reports DNS server port

    Signed-off-by: DL6ER <dl6er@dl6er.de>
    DL6ER committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    43f79ae View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2021

  1. Merge pull request #1264 from pi-hole/new/telnet-dns-port

    Return DNS port on ">dns-port" telnet command
    DL6ER authored Dec 29, 2021
    Configuration menu
    Copy the full SHA
    e9db358 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2021

  1. Count immortal cache entries as valid. They can just never expire.

    Signed-off-by: DL6ER <dl6er@dl6er.de>
    DL6ER committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    7c0a9c1 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1267 from pi-hole/tweak/cache_info

    Fix cache statistics
    DL6ER authored Dec 30, 2021
    Configuration menu
    Copy the full SHA
    c190eab View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2021

  1. Configuration menu
    Copy the full SHA
    7f61a59 View commit details
    Browse the repository at this point in the history
  2. Fix wrong client address for dhcp-script when DHCPv4 relay in use.

    Signed-off-by: DL6ER <dl6er@dl6er.de>
    simonkelley authored and DL6ER committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    5c41929 View commit details
    Browse the repository at this point in the history
  3. Add snooping of DHCPv6 prefix delegation to the DHCP-relay function.

    Signed-off-by: DL6ER <dl6er@dl6er.de>
    simonkelley authored and DL6ER committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    e519fcf View commit details
    Browse the repository at this point in the history
  4. Finesse parsing of --dhcp-remoteid and --dhcp-subscrid.

    To be treated as hex, the pattern must consist of only hex digits AND
    contain at least one ':'. Thanks to Bengt-Erik Sandstrom who tripped
    over a pattern consisting of a decimal number which was interpreted
    surprisingly.
    
    Signed-off-by: DL6ER <dl6er@dl6er.de>
    simonkelley authored and DL6ER committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    edf70fc View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2022

  1. Merge pull request #1266 from pi-hole/master

    Sync master -> development
    PromoFaux authored Jan 1, 2022
    Configuration menu
    Copy the full SHA
    dcaa3c4 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2022

  1. Check E(ffective) in addition of P(ermitted) capabilities flag. E is …

    …what the kernel actually checks, P is a limiting superset for the capabilities that could be added to the E and I(nheritable) sets. We need both as TCP workers will be forks.
    
    Signed-off-by: DL6ER <dl6er@dl6er.de>
    DL6ER committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    a5af39f View commit details
    Browse the repository at this point in the history
  2. Do not warn about missing capabilities during startup. The embedded d…

    …nsmasq does the same but config-aware, i.e. it will not complain about missing CAP_NET_ADMIN when DHCP is not used. As its warnings are now much more present in all logs, we don't need to do the check twice. The existing checks remain there but are only used in debug mode (DEBUG_CAPS).
    
    Signed-off-by: DL6ER <dl6er@dl6er.de>
    DL6ER committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    646e709 View commit details
    Browse the repository at this point in the history
  3. Remove check for CAP_IPC_LOCK as we are not using mlock() anywhere in…

    … the code
    
    Signed-off-by: DL6ER <dl6er@dl6er.de>
    DL6ER committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    3634ba2 View commit details
    Browse the repository at this point in the history
  4. Update SQLite to v3.37.1

    Signed-off-by: DL6ER <dl6er@dl6er.de>
    DL6ER committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    912ce90 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1270 from pi-hole/fix/capabilites_check

    Improve Linux capabilities check
    DL6ER authored Jan 2, 2022
    Configuration menu
    Copy the full SHA
    6621dd1 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #1271 from pi-hole/update/sqlite_3.37.1

    Update SQLite to v3.37.1
    DL6ER authored Jan 2, 2022
    Configuration menu
    Copy the full SHA
    b265818 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. Include client address if TFTP file-not-found errors.

    Signed-off-by: DL6ER <dl6er@dl6er.de>
    simonkelley authored and DL6ER committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    15a389b View commit details
    Browse the repository at this point in the history
  2. src/option.c: fix build with gcc 4.8

    Fix the following build failure with gcc 4.8 raised since version 2.86:
    
    option.c: In function 'one_opt':
    option.c:2445:11: error: 'for' loop initial declarations are only allowed in C99 mode
               for (char *p = arg; *p; p++) {
               ^
    option.c:2445:11: note: use option -std=c99 or -std=gnu99 to compile your code
    option.c:2453:11: error: 'for' loop initial declarations are only allowed in C99 mode
               for (u8 i = 0; i < sizeof(daemon->umbrella_device); i++, arg+=2) {
               ^
    
    Fixes:
     - http://autobuild.buildroot.org/results/39b34a4e69fc10f4bd9d4ddb0ed8c0aae5741c84
    
    Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
    Signed-off-by: DL6ER <dl6er@dl6er.de>
    ffontaine authored and DL6ER committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    5e4dd99 View commit details
    Browse the repository at this point in the history
  3. Fix 46312909d9080ff8743133fbd52427b4b2213171 typo.

    Signed-off-by: DL6ER <dl6er@dl6er.de>
    simonkelley authored and DL6ER committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    3a6b222 View commit details
    Browse the repository at this point in the history
  4. Tidy code for --umbrella option.

    Signed-off-by: DL6ER <dl6er@dl6er.de>
    simonkelley authored and DL6ER committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    a94e061 View commit details
    Browse the repository at this point in the history
  5. src/option.c: fix build with gcc 4.8

    Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
    Signed-off-by: DL6ER <dl6er@dl6er.de>
    ffontaine authored and DL6ER committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    7b3df66 View commit details
    Browse the repository at this point in the history
  6. Fix fail to build when NO_SCRIPT set.

    Signed-off-by: DL6ER <dl6er@dl6er.de>
    simonkelley authored and DL6ER committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    9deef84 View commit details
    Browse the repository at this point in the history
  7. Fix crash after re-reading an empty resolv.conf file.

    If dnsmasq re-reads a resolv file, and it's empty, it will
    retry after a delay. In the meantime, the old servers from the
    resolv file have been deleted, but the servers_array doesn't
    get updated, leading to dangling pointers and crashes.
    
    Thanks to Brad Jorsch for finding and analysing this bug.
    
    This problem was introduced in 2.86.
    
    Signed-off-by: DL6ER <dl6er@dl6er.de>
    simonkelley authored and DL6ER committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    4055793 View commit details
    Browse the repository at this point in the history
  8. Use host byte-order variable for answer counting.

    Signed-off-by: DL6ER <dl6er@dl6er.de>
    simonkelley authored and DL6ER committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    6fd4594 View commit details
    Browse the repository at this point in the history
  9. Fix logic in add_update_server() to make optimisation actually optimise.

    Signed-off-by: DL6ER <dl6er@dl6er.de>
    simonkelley authored and DL6ER committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    84b0f7e View commit details
    Browse the repository at this point in the history
  10. Fix massive confusion on server reload.

    The 2.86 upstream server rewrite severely broke re-reading
    of server configuration. It would get everyting right the first
    time, but on re-reading /etc/resolv.conf or --servers-file
    or setting things with DBUS, the results were just wrong.
    
    This should put things right again.
    
    Signed-off-by: DL6ER <dl6er@dl6er.de>
    simonkelley authored and DL6ER committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    83ec0e7 View commit details
    Browse the repository at this point in the history
  11. Update dnsmasq version

    Signed-off-by: DL6ER <dl6er@dl6er.de>
    DL6ER committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    7cb11e2 View commit details
    Browse the repository at this point in the history
  12. Minor tweaks

    Signed-off-by: DL6ER <dl6er@dl6er.de>
    DL6ER committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    6a6e2ff View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Merge pull request #1273 from pi-hole/update/dnsmasq

    Update embedded dnsmasq
    DL6ER authored Jan 5, 2022
    Configuration menu
    Copy the full SHA
    1aaa6b4 View commit details
    Browse the repository at this point in the history