Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute "." for empty domain names #1413

Merged
merged 1 commit into from
Aug 28, 2022
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Aug 27, 2022

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Substitute "." from empty domain names passed by dnsmasq. This PR extends the already existing facility from internally generated DNSSEC queries also to regular queries.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from yubiuser August 27, 2022 11:25
@DL6ER DL6ER changed the title Substitute "." from empty domain names Substitute "." for empty domain names Aug 27, 2022
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Benefit is also that queries for . are now also stored in the long-term database. They have been stored before as well (but of course as empty domain)

@yubiuser yubiuser merged commit 26c0f59 into development Aug 28, 2022
@yubiuser yubiuser deleted the tweak/dot_empty_domain branch August 28, 2022 17:59
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/regex-for-blocking-just-dot-as-domain/57319/13

@DL6ER DL6ER mentioned this pull request Oct 30, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants