Revert empty domain dot replacement #2314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Reverts #1244. This was introduced to replace "empty" domain strings with a dot (
.
). For historic reasons,dnsmasq
strippes all trailing dots. If a query consists only of the dot (root zone),FTL
has been seeing only an empty domain so far. FTL PR pi-hole/FTL#1413 changes this behavior, therefore, the mock-up introduced by #1244 is no longer needed.By submitting this pull request, I confirm the following:
git rebase
)