Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uBlock Origin blocks some of the UI #850

Closed
3 tasks done
Random90 opened this issue Sep 28, 2018 · 2 comments
Closed
3 tasks done

uBlock Origin blocks some of the UI #850

Random90 opened this issue Sep 28, 2018 · 2 comments

Comments

@Random90
Copy link

Random90 commented Sep 28, 2018

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

How familiar are you with the the source code relevant to this issue?:

7


Expected behaviour:

Proper display of statistics on the index page

Actual behaviour:

Queries Blocked and Percent Blocked don't display properly.
obraz

Steps to reproduce:

Just view main page with uBlock origin enabled

Debug token provided by uploading pihole -d log:

No need

Troubleshooting undertaken, and/or other relevant information:

The problem is a part of uBlock origin cosmetic blocking filter: '[id^="ads_"]'
Changing id of
<span id="ads_blocked_today" class="">---</span> and
<span id="ads_percentage_today" class="">---</span>
to something else would fix issue for any uBlockOrigin users.
I know I can fix it just by turning uBlock Origin off, but it took quite some time for me to realize that is not a pihole UI problem.

@rrobgill
Copy link
Contributor

rrobgill commented Sep 29, 2018

Instead of disabling ublock origin entirely, you can disable cosmetic filtering on a per-site basis, and just disable it on your pi-hole, as a temporary fix until the blocklist is corrected.

This is not a bug with pi-hole, or ublock origin, but as you have pointed out, an overzealous filter entry from one or more filter lists. (It may be good if you could report the false positive to the maintainer of the filter list that contains it, they may be able to add a whitelist entry to work around it).

@Random90
Copy link
Author

It may be good if you could report the false positive to the maintainer of the filter list that contains it, they may be able to add a whitelist entry to work around it
You are right, sorry for bothering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants