Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ad blockers from blocking query log UI elements #2038

Closed
wants to merge 5 commits into from

Conversation

Iksas
Copy link
Contributor

@Iksas Iksas commented Dec 29, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

This PR fixes an issue where certain ad blockers block elements with an ID starting with ads_.
In the past, a similar issue has been discussed in #850.

Before:
before

After:
after

How does this PR accomplish the above?:

In the IDs of the affected elements, ads_ is replaced with queries_.
An identical solution has already been implemented for the elements mentioned in #850.

What documentation changes (if any) are needed to support this PR?:

none

@Iksas Iksas marked this pull request as draft December 29, 2021 20:35
@Iksas Iksas closed this Dec 29, 2021
@Iksas Iksas deleted the query-log-rename branch December 29, 2021 20:43
@Iksas
Copy link
Contributor Author

Iksas commented Dec 29, 2021

See #2039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants