Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ad blockers from blocking query log UI elements #2039

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

Iksas
Copy link
Contributor

@Iksas Iksas commented Dec 29, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

This PR fixes an issue where certain ad blockers block elements with an ID starting with ads_.
In the past, a similar issue has been discussed in #850.

Before:
before

After:
after

How does this PR accomplish the above?:

In the IDs of the affected elements, ads_ is replaced with queries_.
An identical solution has already been implemented for the elements mentioned in #850.

What documentation changes (if any) are needed to support this PR?:

none

Signed-off-by: Iksas <Iksas@users.noreply.github.com>
@rdwebdesign
Copy link
Member

I'm not sure this is a pi-hole bug/problem.

The issue you mentioned (#850) was closed by the author after he agreed to this comment:

Instead of disabling ublock origin entirely, you can disable cosmetic filtering on a per-site basis, and just disable it on your pi-hole, as a temporary fix until the blocklist is corrected.

This is not a bug with pi-hole, or ublock origin, but as you have pointed out, an overzealous filter entry from one or more filter lists. (It may be good if you could report the false positive to the maintainer of the filter list that contains it, they may be able to add a whitelist entry to work around it).

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same change we made in #1296
And I can only cite from there

Whilst technically "not our problem" it's simple enough to do and saves the occasional confusion when these two elements have no information in them.

Interestingly, it took 2 years to

not sure if there are other places that need the changes made, guess we'll find out!

@DL6ER DL6ER merged commit 8f28794 into pi-hole:devel Jan 2, 2022
@PromoFaux PromoFaux mentioned this pull request Jan 4, 2022
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-13-web-v5-10-and-core-v5-8-released/52254/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants