Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisible buttons in password fields (desktop Safari) #2020

Merged
merged 1 commit into from
Dec 26, 2021

Conversation

Iksas
Copy link
Contributor

@Iksas Iksas commented Dec 24, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

When using dark themes in desktop Safari, the autofill button cannot be seen because it's colored black on a black background. For the same reason, the caps lock indicator cannot be seen. This PR fixes both issues.

How does this PR accomplish the above?:

The issues are fixed by using the text color for the autofill button, and by inverting the caps lock indicator:

dark

darker

lcars

What documentation changes (if any) are needed to support this PR?:

none

@yubiuser
Copy link
Member

What's about the other themes? Do they offer an caps-lock indicator that needs to be fixed?

Are the indicators browser-dependent? I haven't seen them on Chrome or Firefox?

@Iksas Iksas force-pushed the password-manager-button-fix branch 2 times, most recently from 49d734f to f63e195 Compare December 24, 2021 11:56
Signed-off-by: Iksas <Iksas@users.noreply.github.com>
@Iksas Iksas force-pushed the password-manager-button-fix branch from f63e195 to 67fa6b3 Compare December 24, 2021 11:58
@Iksas Iksas changed the title Fix invisible buttons in password field of LCARS theme (desktop Safari) Fix invisible buttons in password fields (desktop Safari) Dec 24, 2021
@Iksas
Copy link
Contributor Author

Iksas commented Dec 24, 2021

You're right, all dark themes are affected. Don't know how I missed this, I have now fixed them all. The color of the password button is now the same as the text color.

The indicators are indeed browser-dependent. Desktop Safari is the only browser that I know of that has them.

Also, please let me know if I have added the fixes in the right lines. It was a bit hard to decide where to put them in default-dark.css

@yubiuser yubiuser merged commit c0dcded into pi-hole:devel Dec 26, 2021
@PromoFaux PromoFaux mentioned this pull request Jan 4, 2022
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-13-web-v5-10-and-core-v5-8-released/52254/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants