Fix glitch of password manager button in dark themes (macOS Safari) #2354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a glitch with the password manager button in dark themes that affects macOS Safari.
Before:
After:
In #2020, a workaround was introduced to fix the appearance of the password manager button on dark backgrounds in macOS Safari. Apple has since fixed the issue. The workaround now breaks the button, so it has been removed.
(The workaround for the caps lock button also introduced in #2020 is still needed, and works fine.)
none
By submitting this pull request, I confirm the following:
git rebase
)