Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glitch of password manager button in dark themes (macOS Safari) #2354

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

Iksas
Copy link
Contributor

@Iksas Iksas commented Sep 15, 2022

  • What does this PR aim to accomplish?:

This PR fixes a glitch with the password manager button in dark themes that affects macOS Safari.

Before:
before

After:
after

  • How does this PR accomplish the above?:

In #2020, a workaround was introduced to fix the appearance of the password manager button on dark backgrounds in macOS Safari. Apple has since fixed the issue. The workaround now breaks the button, so it has been removed.

(The workaround for the caps lock button also introduced in #2020 is still needed, and works fine.)

  • What documentation changes (if any) are needed to support this PR?:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser
Copy link
Member

Thanks for your PR. Could you please rebase on latest devel and force push?

Signed-off-by: Iksas <Iksas@users.noreply.github.com>
@Iksas
Copy link
Contributor Author

Iksas commented Sep 15, 2022

Ah my bad. Now it should be fixed.

@yubiuser yubiuser merged commit 5cf3c49 into pi-hole:devel Sep 15, 2022
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-18-1-web-v5-15-1-and-core-v5-12-2-released/58022/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants