Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve appearance of the main menu #2023

Merged
merged 1 commit into from
Dec 24, 2021
Merged

Improve appearance of the main menu #2023

merged 1 commit into from
Dec 24, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 24, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Improve the appearance of the main menu

How does this PR accomplish the above?:

Use fixed width icons everywhere and add some margin to the icons to make icon/text less squeezed.

ezgif-2-5c38e47087

What documentation changes (if any) are needed to support this PR?:

None

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team December 24, 2021 13:21
@DL6ER DL6ER merged commit 9393b2e into devel Dec 24, 2021
@DL6ER DL6ER deleted the fix/menu_icons branch December 24, 2021 14:49
yubiuser pushed a commit that referenced this pull request Dec 26, 2021
Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
@DL6ER
Copy link
Member Author

DL6ER commented Dec 31, 2021

Partially reverted in #2041

@PromoFaux PromoFaux mentioned this pull request Jan 4, 2022
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-13-web-v5-10-and-core-v5-8-released/52254/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants