-
-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to filter domains by type #2334
Conversation
6253b04
to
984418d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deselected all checkboxes, but instead of showing no domains it switched back to show all domains. This is kind of counter-intuitive. Is this the expected behavior?
I wonder if this makes the page again somewhat more complex to use. This also requires extra amounts of space, if we keep it, could we explore having this in the box-header instead of in a dedicated row? |
Answering each question:
Yes.
I thought about that and I think is a great idea. I only put the filter with the other controls because I think nobody would like it there. |
5ae7f13
to
4da41e1
Compare
e581de6
to
262a5cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new position of the checkboxes, it fits in there very well. I would just change the order of "Exact blacklist" and "RegEx whitelist", so both withlist and both blacklist boxes are grouped. This makes it easier to "restore" the old function to only see whitelist/blacklist entries.
Is this the expected behavior?
Yes.
After testing, I decided to start with all selected, but keep the "show all", if none are selected (I don't see a reason to hide all).
Sure it makes no sense to deselect all and expect any output - however, I would argue one would expect to see an empty table then.
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
- change checkboxes order; - remove all lines if all checkboxes are unselected. Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
76fa441
to
4d8b19f
Compare
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/color-coding-domain-type/57763/3 |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/i-cant-find-my-whitelist-in-the-new-version/57759/5 |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/whitelist-and-blacklist/57563/9 |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-18-web-v5-15-and-core-v5-12-1-released/57894/1 |
What does this PR aim to accomplish?:
After a recent update, all domains are shown on the same page.
This PR adds the ability to filter domains by type, allowing turn on/off the visibility of:
How does this PR accomplish the above?:
Adding a filter and checkboxes to control the filter.
What documentation changes (if any) are needed to support this PR?:
none.
By submitting this pull request, I confirm the following:
git rebase
)