Added docs for DragDrop Events and Key Events #2650
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwensley
reviewed
May 1, 2024
| @@ -131,7 +131,9 @@ protected virtual void OnSizeChanged(EventArgs e) | |||
| public const string KeyDownEvent = "Control.KeyDown"; | |||
|
|
|||
| /// <summary> | |||
| /// Occurs when a key has been pressed and is down | |||
| /// Occurs when a key has been pressed and is down. | |||
| /// Focus is required for this event to be raised. Ensure CanFocus is set to true. | |||
There was a problem hiding this comment.
CanFocus is only on a Drawable. Other controls intrinsically can get focus like TextBox, TextArea, DropDown, CheckBox, etc when they are Enabled
cwensley
reviewed
May 1, 2024
| @@ -1213,11 +1218,11 @@ public Window ParentWindow | |||
| public IEnumerable<string> SupportedPlatformCommands => Handler.SupportedPlatformCommands; | |||
|
|
|||
| /// <summary> | |||
| /// Specifies a command to execute for a platform-specific command | |||
| /// Specifies a command to execute for a Mac platform-specific command | |||
There was a problem hiding this comment.
This would also be used for any other platform that has similar needs, not just Mac. Even though it is only useful for Mac at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using Eto more and more so I'm going to try and improve docs for things that confused me