Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use apex 2.7.1 in CI which fixes shutdown use-after-free #1363

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Dec 5, 2024

2.7.1 includes which UO-OACISS/apex@cde877d should fix UO-OACISS/apex#182.

Fixes #1353.

@msimberg msimberg added this to the 0.31.0 milestone Dec 5, 2024
@msimberg msimberg self-assigned this Dec 5, 2024
Copy link

codacy-production bot commented Dec 5, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.21% (target: -1.00%) (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (28b0fbf) 18217 13766 75.57%
Head commit (f7b0d90) 18223 (+6) 13733 (-33) 75.36% (-0.21%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1363) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@msimberg
Copy link
Contributor Author

It looks like this indeed works. Not merging until a new version of apex is available for use in CI though.

@msimberg msimberg removed this from the 0.31.0 milestone Dec 10, 2024
@msimberg
Copy link
Contributor Author

A new version of apex (2.7.1) has been tagged. Waiting for it to be available in spack.

@msimberg msimberg changed the title Use apex develop commit which fixes shutdown use-after-free Use apex 2.7.1 in CI which fixes shutdown use-after-free Dec 16, 2024
@msimberg msimberg marked this pull request as ready for review December 16, 2024 09:41
@msimberg msimberg enabled auto-merge December 16, 2024 12:59
@msimberg
Copy link
Contributor Author

The HIP 6 CI configuration is broken after the spack commit bump in this PR. This needs more investigation.

Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@msimberg
Copy link
Contributor Author

Investigating the HIP issues separately in #1381.

@msimberg msimberg marked this pull request as draft December 19, 2024 13:55
auto-merge was automatically disabled December 19, 2024 13:55

Pull request was converted to draft

@msimberg msimberg force-pushed the apex-develop-ci branch 2 times, most recently from bf1e056 to f7b0d90 Compare January 13, 2025 10:10
@msimberg
Copy link
Contributor Author

#1381 updates the spack commit to one that fixes the HIP installation issue. Once that's merged, we can attempt to merge this.

@msimberg msimberg marked this pull request as ready for review January 20, 2025 18:01
@msimberg
Copy link
Contributor Author

#1381 was merged, continuing with this one as well now.

@msimberg msimberg enabled auto-merge January 20, 2025 18:01
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.09% (target: -1.00%) (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f451c4d) 18223 13740 75.40%
Head commit (b8fb5fd) 18223 (+0) 13724 (-16) 75.31% (-0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1363) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@msimberg msimberg added this pull request to the merge queue Jan 20, 2025
Merged via the queue into pika-org:main with commit 1ab788b Jan 20, 2025
40 of 42 checks passed
@msimberg msimberg deleted the apex-develop-ci branch January 20, 2025 20:31
@msimberg msimberg added this to the 0.32.0 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Don't allow failures on APEX CI configuration Use after free in read_proc
2 participants