-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use apex 2.7.1 in CI which fixes shutdown use-after-free #1363
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
It looks like this indeed works. Not merging until a new version of apex is available for use in CI though. |
cb752e6
to
6095a82
Compare
A new version of apex (2.7.1) has been tagged. Waiting for it to be available in spack. |
6095a82
to
19a4f6d
Compare
19a4f6d
to
4b7f1c4
Compare
The HIP 6 CI configuration is broken after the spack commit bump in this PR. This needs more investigation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Investigating the HIP issues separately in #1381. |
Pull request was converted to draft
bf1e056
to
f7b0d90
Compare
#1381 updates the spack commit to one that fixes the HIP installation issue. Once that's merged, we can attempt to merge this. |
Disallow failures again. The apex commit fixes UO-OACISS/apex#182.
f7b0d90
to
b8fb5fd
Compare
#1381 was merged, continuing with this one as well now. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
2.7.1 includes which UO-OACISS/apex@cde877d should fix UO-OACISS/apex#182.
Fixes #1353.