Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spack commit used in CI #1381

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

msimberg
Copy link
Contributor

Separating the commit update from #1363.

Copy link

codacy-production bot commented Dec 19, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.08% (target: -1.00%) (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (664c138) 18223 13740 75.40%
Head commit (c9faa7e) 18223 (+0) 13726 (-14) 75.32% (-0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1381) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@msimberg msimberg force-pushed the spack-commit-ci-update branch from 8a07f80 to 0754514 Compare January 14, 2025 12:28
Comment on lines 8 to 11
# - local: '.gitlab/includes/gcc13_pipeline.yml'
# - local: '.gitlab/includes/clang14_cuda11_pipeline.yml'
- local: '.gitlab/includes/gcc12_hip6_pipeline.yml'
- local: '.gitlab/includes/sloc.yml'
# - local: '.gitlab/includes/sloc.yml'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert.

@msimberg msimberg marked this pull request as ready for review January 14, 2025 12:31
@msimberg
Copy link
Contributor Author

spack/spack#48549 should finally fix the HIP installation issue. I've updated the spack commit to the next develop-* tag, which will be available in a week. Once the tag is there we can try merging this.

@msimberg msimberg force-pushed the spack-commit-ci-update branch 2 times, most recently from 4dd363e to c9faa7e Compare January 20, 2025 13:43
@msimberg msimberg enabled auto-merge January 20, 2025 13:43
@msimberg msimberg added this pull request to the merge queue Jan 20, 2025
Merged via the queue into pika-org:main with commit f451c4d Jan 20, 2025
40 of 42 checks passed
@msimberg msimberg deleted the spack-commit-ci-update branch January 20, 2025 17:56
@msimberg msimberg added this to the 0.32.0 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant