Get rid of unnecessary Flutter binding assertions in tests (#337)

* Get rid of unnecessary Flutter binding assertion in tests * Improve wording in README * Remove streamable views task form README
pinchbv · May 23, 2020 · 9fa2bb5 · 9fa2bb5
1 parent 527b0cb
commit 9fa2bb5
Show file tree

Hide file tree

Showing 9 changed files with 4 additions and 22 deletions.
diff --git a/README.md b/README.md
@@ -2,7 +2,7 @@
 
 Floor provides a neat SQLite abstraction for your Flutter applications inspired by the [Room persistence library](https://developer.android.com/topic/libraries/architecture/room).
 It comes with automatic mapping between in-memory objects and database rows while still offering full control of the database with the use of SQL.
-In order to harvest Floor's full potential, it's necessary to have an understanding of SQL and SQLite.
+As a consequence, it's necessary to have an understanding of SQL and SQLite in order to harvest Floor's full potential.
 
 - typesafe
 - reactive
@@ -13,7 +13,7 @@ In order to harvest Floor's full potential, it's necessary to have an understand
 - iOS, Android, Linux, macOS, Windows
 
 ⚠️ The library is on its way to its first stable release!
-After integrating type converters, embeddable objects and streamable database views, the API surface won't change until after 1.0.
+After integrating type converters and embeddable objects, the API surface won't change until after 1.0.
 
 [![pub package](https://img.shields.io/pub/v/floor.svg)](https://pub.dartlang.org/packages/floor)
 [![build status](https://github.com/vitusortner/floor/workflows/Continuous%20integration/badge.svg)](https://github.com/vitusortner/floor/actions)
@@ -611,8 +611,6 @@ import 'database.dart';
 import 'entity/person.dart';
 
 void main() {
-  TestWidgetsFlutterBinding.ensureInitialized();
-
   group('database tests', () {
     TestDatabase database;
     PersonDao personDao;

diff --git a/example/test/main_test.dart b/example/test/main_test.dart
@@ -5,8 +5,6 @@ import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
 
 void main() {
-  TestWidgetsFlutterBinding.ensureInitialized();
-
   FlutterDatabase database;
   TaskDao taskDao;
 

diff --git a/floor/README.md b/floor/README.md
@@ -2,7 +2,7 @@
 
 Floor provides a neat SQLite abstraction for your Flutter applications inspired by the [Room persistence library](https://developer.android.com/topic/libraries/architecture/room).
 It comes with automatic mapping between in-memory objects and database rows while still offering full control of the database with the use of SQL.
-In order to harvest Floor's full potential, it's necessary to have an understanding of SQL and SQLite.
+As a consequence, it's necessary to have an understanding of SQL and SQLite in order to harvest Floor's full potential.
 
 - typesafe
 - reactive
@@ -13,7 +13,7 @@ In order to harvest Floor's full potential, it's necessary to have an understand
 - iOS, Android, Linux, macOS, Windows
 
 ⚠️ The library is on its way to its first stable release!
-After integrating type converters, embeddable objects and streamable database views, the API surface won't change until after 1.0.
+After integrating type converters and embeddable objects, the API surface won't change until after 1.0.
 
 [![pub package](https://img.shields.io/pub/v/floor.svg)](https://pub.dartlang.org/packages/floor)
 [![build status](https://github.com/vitusortner/floor/workflows/Continuous%20integration/badge.svg)](https://github.com/vitusortner/floor/actions)
@@ -611,8 +611,6 @@ import 'database.dart';
 import 'entity/person.dart';
 
 void main() {
-  TestWidgetsFlutterBinding.ensureInitialized();
-
   group('database tests', () {
     TestDatabase database;
     PersonDao personDao;

diff --git a/floor/test/integration/blob/blob_test.dart b/floor/test/integration/blob/blob_test.dart
@@ -10,8 +10,6 @@ import 'package:sqflite/sqflite.dart' as sqflite;
 part 'blob_test.g.dart';
 
 void main() {
-  TestWidgetsFlutterBinding.ensureInitialized();
-
   group('BLOB tests', () {
     TestDatabase database;
     PersonDao personDao;

diff --git a/floor/test/integration/boolean_conversions/bool_test.dart b/floor/test/integration/boolean_conversions/bool_test.dart
@@ -8,8 +8,6 @@ import 'package:sqflite/sqflite.dart' as sqflite;
 part 'bool_test.g.dart';
 
 void main() {
-  TestWidgetsFlutterBinding.ensureInitialized();
-
   group('Bool tests', () {
     TestDatabase database;
     BoolDao boolDao;

diff --git a/floor/test/integration/database_test.dart b/floor/test/integration/database_test.dart
@@ -11,8 +11,6 @@ import 'model/dog.dart';
 import 'model/person.dart';
 
 void main() {
-  TestWidgetsFlutterBinding.ensureInitialized();
-
   group('database tests', () {
     TestDatabase database;
     PersonDao personDao;

diff --git a/floor/test/integration/inheritance/dao_inheritance_test.dart b/floor/test/integration/inheritance/dao_inheritance_test.dart
@@ -8,8 +8,6 @@ import 'package:sqflite/sqflite.dart' as sqflite;
 part 'dao_inheritance_test.g.dart';
 
 void main() {
-  TestWidgetsFlutterBinding.ensureInitialized();
-
   group('dao inheritance tests', () {
     TestDatabase database;
     PersonDao personDao;

diff --git a/floor/test/integration/stream_query_test.dart b/floor/test/integration/stream_query_test.dart
@@ -7,8 +7,6 @@ import 'model/dog.dart';
 import 'model/person.dart';
 
 void main() {
-  TestWidgetsFlutterBinding.ensureInitialized();
-
   group('stream query tests', () {
     TestDatabase database;
     PersonDao personDao;

diff --git a/floor/test/integration/view/view_test.dart b/floor/test/integration/view/view_test.dart
@@ -28,8 +28,6 @@ abstract class ViewTestDatabase extends FloorDatabase {
 }
 
 void main() {
-  TestWidgetsFlutterBinding.ensureInitialized();
-
   group('database tests', () {
     ViewTestDatabase database;
     PersonDao personDao;