Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of unnecessary Flutter binding assertions in tests #337

Merged
merged 4 commits into from
May 23, 2020

Conversation

vitusortner
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #337 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #337   +/-   ##
========================================
  Coverage    81.43%   81.43%           
========================================
  Files           59       59           
  Lines         1503     1503           
========================================
  Hits          1224     1224           
  Misses         279      279           
Flag Coverage Δ
#floor 81.43% <ø> (ø)
#floor_generator 81.09% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 527b0cb...3779e50. Read the comment docs.

@vitusortner vitusortner changed the title Get rid of unnecessary Flutter binding assertion in tests Get rid of unnecessary Flutter binding assertions in tests May 23, 2020
@vitusortner vitusortner marked this pull request as ready for review May 23, 2020 18:45
@vitusortner vitusortner requested a review from mqus May 23, 2020 18:45
Copy link
Collaborator

@mqus mqus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After integrating type converters and embeddable objects, the API surface won't change until after 1.0.

I'm not really sure about the API surface not changing (see Transactions instead of Database in #81) but I agree that those are pretty minor (and also not really part of this PR)

@vitusortner
Copy link
Collaborator Author

My intention was to give an overview of which big features are being developed right now and thus, will go into the 1.0 release. We could look into defining a more detailed list in the form of a roadmap. This might also give us a better overview of the current and future state of the library.

@vitusortner vitusortner merged commit 9fa2bb5 into develop May 23, 2020
@vitusortner vitusortner deleted the simplify-integration-tests branch May 23, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants