This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
cmd: don't use ':' in the default log file name #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
==========================================
- Coverage 70.67% 70.36% -0.32%
==========================================
Files 48 48
Lines 4744 4744
==========================================
- Hits 3353 3338 -15
- Misses 950 965 +15
Partials 441 441
Continue to review full report at Codecov.
|
|
LGTM |
3pointer
approved these changes
Apr 16, 2020
3pointer
pushed a commit
to 3pointer/br
that referenced
this pull request
Apr 26, 2020
kennytm
added a commit
that referenced
this pull request
Apr 26, 2020
* enable tidb config by default (#230) * enable tidb config by default * backup,restore: fix --checksum flag. (#223) * backup,restore: work on progress to fix a bug that causes --checksum flag won't work properly. Some code of backup and restore ignored the flag (a.k.a. config.Checksum), so when checksum is disabled, we will face failure. * backup: backup will report total bytes and kvs when checksums check disabled. Some code of backup and restore ignored the flag (a.k.a. config.Checksum), so when checksum is disabled, we will face failure. * backup: backup will report total bytes and kvs when checksums check disabled. Some code of backup and restore ignored the flag (a.k.a. config.Checksum), so when checksum is disabled, we will face failure. * backup: add log to ChecksumMatches and new version of FastChecksum. Some of log has been lose. They are in ChecksumMatches now. * restore: restore could find non-checksum tables and skip them automatically. for backup, ChecksumMatches returns error now. * misc: add document for Table::NoChecksum. * backup: omit checksum progress bar when user specify `--checksum=false`. * backup: `CopyMetaFrom` overrides original `client.Schemes` instead of append at its end. * backup: refactor about checksum logic, fix a bug. the bug would cause: when multi tables are backup, the metadata contains only one table. * backup: do some lints. * backup,restore: do some refactor so that cyclomatic complexity won't be too large. * misc: don't use underscore on receiver. * backup: print "quick checksum success" message per table. ...to make br_full_index happy! * backup: refactor a MinInt pattern. * backup: Apply suggestions from code review Co-Authored-By: kennytm <kennytm@gmail.com> Co-authored-by: 3pointer <luancheng@pingcap.com> Co-authored-by: kennytm <kennytm@gmail.com> * Use table info (#231) * create with info during incremental restore * add test * fix log * address comment * fix ci * address commemnt * backup: generate backupmeta when backup empty. (#235) * cmd: don't use ':' in the default log file name (#236) * Update build status badge (#239) * pass sse_kms_key_id to S3 (#243) * redirect kvproto Signed-off-by: Yi Wu <yiwu@pingcap.com> * pass sse_kms_key_id Signed-off-by: Yi Wu <yiwu@pingcap.com> * fix hound Signed-off-by: Yi Wu <yiwu@pingcap.com> * update kvproto Signed-off-by: Yi Wu <yiwu@pingcap.com> * go mod tidy Signed-off-by: Yi Wu <yiwu@pingcap.com> Co-authored-by: kennytm <kennytm@gmail.com> * storage: support placing the S3/GCS options into the storage URL (#246) * update 4.0 dependency * go mod tidy * Update README.md Co-Authored-By: Neil Shen <overvenus@gmail.com> Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com> Co-authored-by: kennytm <kennytm@gmail.com> Co-authored-by: Neil Shen <overvenus@gmail.com> Co-authored-by: yiwu-arbug <yiwu@pingcap.com>
3pointer
pushed a commit
to 3pointer/br
that referenced
this pull request
Apr 26, 2020
3pointer
added a commit
that referenced
this pull request
Apr 26, 2020
* backup: generate backupmeta when backup empty. (#235) * cmd: don't use ':' in the default log file name (#236) * Update build status badge (#239) * tools: replace retool by GO111MODULE (#244) * tools: replace retool by GO111MODULE * Makefile: temporarily shut up golangci-lint * Restore with lower case (#240) * restore: use lower string to filter since we use lower string to filter backup Co-authored-by: kennytm <kennytm@gmail.com> * storage: support placing the S3/GCS options into the storage URL (#246) * Rebase auto random counter after restore (#248) * *: support auto random backup & restore * update release 3.1 Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com> Co-authored-by: kennytm <kennytm@gmail.com> Co-authored-by: Neil Shen <overvenus@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
:is not a valid filename character for NTFS. The default log file path contains a:and thus invalid.What is changed and how it works?
Replace the
:in the filename by..Check List
Tests
bin/br --helpand check the output.Code changes
Side effects
Related changes