Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

README: update build status badge #239

Merged
merged 1 commit into from
Apr 20, 2020
Merged

README: update build status badge #239

merged 1 commit into from
Apr 20, 2020

Conversation

overvenus
Copy link
Member

Update build status badge.

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #239 into master will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   70.57%   70.27%   -0.30%     
==========================================
  Files          48       48              
  Lines        4744     4744              
==========================================
- Hits         3348     3334      -14     
- Misses        956      967      +11     
- Partials      440      443       +3     
Impacted Files Coverage Δ
pkg/restore/import.go 66.66% <0.00%> (-4.02%) ⬇️
pkg/mock/mock_cluster.go 72.91% <0.00%> (-2.09%) ⬇️
pkg/restore/split_client.go 50.48% <0.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c37f3...cb4a831. Read the comment docs.

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGTM1 label Apr 18, 2020
@3pointer 3pointer merged commit d10e7dc into master Apr 20, 2020
@kennytm kennytm deleted the overvenus-patch-1 branch April 20, 2020 08:00
3pointer pushed a commit to 3pointer/br that referenced this pull request Apr 26, 2020
kennytm added a commit that referenced this pull request Apr 26, 2020
* enable tidb config by default (#230)

* enable tidb config by default

* backup,restore: fix --checksum flag. (#223)

* backup,restore: work on progress to fix a bug that causes --checksum flag won't work properly.

Some code of backup and restore ignored the flag (a.k.a. config.Checksum), so when checksum is disabled, we will face failure.

* backup: backup will report total bytes and kvs when checksums check disabled.

Some code of backup and restore ignored the flag (a.k.a. config.Checksum), so when checksum is disabled, we will face failure.

* backup: backup will report total bytes and kvs when checksums check disabled.

Some code of backup and restore ignored the flag (a.k.a. config.Checksum), so when checksum is disabled, we will face failure.

* backup: add log to ChecksumMatches and new version of FastChecksum.

Some of log has been lose. They are in ChecksumMatches now.

* restore: restore could find non-checksum tables and skip them automatically.

for backup, ChecksumMatches returns error now.

* misc: add document for Table::NoChecksum.

* backup: omit checksum progress bar when user specify `--checksum=false`.

* backup: `CopyMetaFrom` overrides original `client.Schemes` instead of append at its end.

* backup: refactor about checksum logic, fix a bug.

the bug would cause: when multi tables are backup, the metadata contains only one table.

* backup: do some lints.

* backup,restore: do some refactor so that cyclomatic complexity won't be too large.

* misc: don't use underscore on receiver.

* backup: print "quick checksum success" message per table.

...to make br_full_index happy!

* backup: refactor a MinInt pattern.

* backup: Apply suggestions from code review

Co-Authored-By: kennytm <kennytm@gmail.com>

Co-authored-by: 3pointer <luancheng@pingcap.com>
Co-authored-by: kennytm <kennytm@gmail.com>

* Use table info (#231)

* create with info during incremental restore

* add test

* fix log

* address comment

* fix ci

* address commemnt

* backup: generate backupmeta when backup empty. (#235)

* cmd: don't use ':' in the default log file name (#236)

* Update build status badge (#239)

* pass sse_kms_key_id to S3 (#243)

* redirect kvproto

Signed-off-by: Yi Wu <yiwu@pingcap.com>

* pass sse_kms_key_id

Signed-off-by: Yi Wu <yiwu@pingcap.com>

* fix hound

Signed-off-by: Yi Wu <yiwu@pingcap.com>

* update kvproto

Signed-off-by: Yi Wu <yiwu@pingcap.com>

* go mod tidy

Signed-off-by: Yi Wu <yiwu@pingcap.com>

Co-authored-by: kennytm <kennytm@gmail.com>

* storage: support placing the S3/GCS options into the storage URL (#246)

* update 4.0 dependency

* go mod tidy

* Update README.md

Co-Authored-By: Neil Shen <overvenus@gmail.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: kennytm <kennytm@gmail.com>
Co-authored-by: Neil Shen <overvenus@gmail.com>
Co-authored-by: yiwu-arbug <yiwu@pingcap.com>
3pointer pushed a commit to 3pointer/br that referenced this pull request Apr 26, 2020
3pointer added a commit that referenced this pull request Apr 26, 2020
* backup: generate backupmeta when backup empty. (#235)

* cmd: don't use ':' in the default log file name (#236)

* Update build status badge (#239)

* tools: replace retool by GO111MODULE (#244)

* tools: replace retool by GO111MODULE

* Makefile: temporarily shut up golangci-lint

* Restore with lower case (#240)

* restore: use lower string to filter since we use lower string to filter backup

Co-authored-by: kennytm <kennytm@gmail.com>

* storage: support placing the S3/GCS options into the storage URL (#246)

* Rebase auto random counter after restore (#248)

* *: support auto random backup & restore

* update release 3.1

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: kennytm <kennytm@gmail.com>
Co-authored-by: Neil Shen <overvenus@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants