This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
restore: set configed keepalive for restore #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3pointer
reviewed
Oct 30, 2020
| @@ -102,7 +102,9 @@ func RunRestore(c context.Context, g glue.Glue, cmdName string, cfg *RestoreConf | |||
| } | |||
| defer mgr.Close() | |||
|
|
|||
| client, err := restore.NewRestoreClient(g, mgr.GetPDClient(), mgr.GetTiKV(), mgr.GetTLSConfig()) | |||
| keepaliveCfg := GetKeepalive(&cfg.Config) | |||
| keepaliveCfg.PermitWithoutStream = true | |||
There was a problem hiding this comment.
How about put this line in GetKeepalive function?
There was a problem hiding this comment.
This function is also used in the backup site, which doesn't needs PermitWithoutStream.
|
/run-integration-tests |
3pointer
pushed a commit
to 3pointer/br
that referenced
this pull request
Nov 6, 2020
* restore: set configed keepalive for restore * restore: remove SetKeepalive
|
cherry pick to release-4.0 in PR #591 |
kennytm
pushed a commit
that referenced
this pull request
Nov 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#545 added the config value of keepalive, but it has forgotten the restore part(!).
What is changed and how it works?
Apply the config to restoring.
Check List
Tests
(If the old tests passed, then the default config should be applied.)
Release Note