Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

restore: set configed keepalive for restore (#567) #591

Merged
merged 3 commits into from
Nov 10, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #567 to release-4.0


What problem does this PR solve?

#545 added the config value of keepalive, but it has forgotten the restore part(!).

What is changed and how it works?

Apply the config to restoring.

Check List

Tests

  • Unit test
  • Integration test
    (If the old tests passed, then the default config should be applied.)

Release Note

  • Fix a bug that causes the keepalive configs don't apply to restore.

@3pointer
Copy link
Collaborator

/rebuild

Copy link
Collaborator

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Nov 10, 2020
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Nov 10, 2020
@kennytm
Copy link
Collaborator

kennytm commented Nov 10, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@kennytm
Copy link
Collaborator

kennytm commented Nov 10, 2020

/run-integration-test

@kennytm kennytm merged commit 253fe72 into pingcap:release-4.0 Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants