This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Fix the issue that rawkv restore's end key is incorrectly inclusive when restoring partial of backed up data (#201) #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen restoring partial of backed up data (pingcap#201) * Fix raw restoe range endKey * Add tests * Address comments Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com> Co-authored-by: 3pointer <luancheng@pingcap.com>
|
|
|
/run-integration-test |
|
@3pointer PTAL. Can this be merged in 4.0.11? |
|
/lgtm |
ti-srebot
approved these changes
Jan 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picks #201 to release-4.0
What problem does this PR solve?
This PR fixes the issue that rawkv restore's end key is incorrectly inclusive when restoring partial of backed up data. See tikv/tikv#7163
What is changed and how it works?
This PR adds is_raw_kv field to DownloadRequest and adds end_key_exclusive field to SstMeta. For SST files that contains the restoring end key in its range, it will cut the file's end key to the restoring endKey, and set end_key_exclusive.
Check List
Tests
Code changes
DownlaodRequestSstMetaSide effects
-
Related changes
Release note