Add end_key_exclude field to SstMeta and distinguish restoring of RawKv #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
reviewed
Mar 22, 2020
|
@kennytm It's generated. Should I remove those changes? |
|
Yeah please revert it. gogoprotoc creates a random name every time it is called, and thus all |
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
…t-meta-exclude-end-key
MyonKeminta
added a commit
to MyonKeminta/kvproto
that referenced
this pull request
May 18, 2020
…Kv (pingcap#581) * Add end_key_exclusive field to SSTMeta * Add is_raw_kv field to download request * Revert changes of unrelated go files Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> * build Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
MyonKeminta
added a commit
to MyonKeminta/kvproto
that referenced
this pull request
May 18, 2020
…Kv (pingcap#581) * Add end_key_exclusive field to SSTMeta * Add is_raw_kv field to download request * Revert changes of unrelated go files Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> * build Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
This was referenced May 18, 2020
Closed
5kbpers
pushed a commit
to 5kbpers/kvproto
that referenced
this pull request
Aug 17, 2020
…Kv (pingcap#581) * Add end_key_exclusive field to SSTMeta * Add is_raw_kv field to download request * Revert changes of unrelated go files Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> * build Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com> Signed-off-by: 5kbpers <tangminghua@pingcap.com>
overvenus
pushed a commit
that referenced
this pull request
Aug 18, 2020
* cdc: add regions field for reducing message of resolved ts Signed-off-by: 5kbpers <tangminghua@pingcap.com> * pdpb: add replicate_mode (#584) Signed-off-by: disksing <i@disksing.com> Signed-off-by: 5kbpers <tangminghua@pingcap.com> * replicate_mode: change recover-id to state-id (#594) Signed-off-by: disksing <i@disksing.com> * replicate: add unknown region state (#595) Signed-off-by: disksing <i@disksing.com> * *: update name and script (#597) Signed-off-by: Jay Lee <BusyJayLee@gmail.com> Signed-off-by: 5kbpers <tangminghua@pingcap.com> * support batch coprocessor (#586) Add batch coprocessor function for TiFlash Engine. Signed-off-by: 5kbpers <tangminghua@pingcap.com> * pd: add UpdateServiceGCSafePoint method (#603) * pd: add UpdateServiceGCSafePoint method Signed-off-by: Shafreeck Sea <shafreeck@gmail.com> Signed-off-by: 5kbpers <tangminghua@pingcap.com> * Add end_key_exclude field to SstMeta and distinguish restoring of RawKv (#581) * Add end_key_exclusive field to SSTMeta * Add is_raw_kv field to download request * Revert changes of unrelated go files Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> * build Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com> Signed-off-by: 5kbpers <tangminghua@pingcap.com> * Revert "cdc: add regions field for reducing message of resolved ts" This reverts commit c382b16. Signed-off-by: 5kbpers <tangminghua@pingcap.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: Jay <BusyJay@users.noreply.github.com> Co-authored-by: Han Fei <hanfei19910905@gmail.com> Co-authored-by: Shafreeck Sea <shafreeck@users.noreply.github.com> Co-authored-by: MyonKeminta <9948422+MyonKeminta@users.noreply.github.com> Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
ti-chi-bot
pushed a commit
to tikv/tikv
that referenced
this pull request
Jan 28, 2021
…ive (#7196) (#9583) cherry-pick #7196 to release-4.0 --- <!-- Thank you for contributing to TiKV! If you haven't already, please read TiKV's [CONTRIBUTING](https://github.com/tikv/tikv/blob/master/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. --> ### What have you changed? Partially fixes #7163 , but it still doesn't work for restoring plain transactional kv (without TiDB). This PR adds is_raw_kv field to DownloadRequest to distinguish rawkv restore requests, and adds end_key_exclusive field to SstMeta so that TiKV knows whether the endkey need to be included.l ### What is the type of the changes? - Bugfix (a change which fixes an issue) ### How is the PR tested? - Unit test - Manual test (add detailed scripts or steps below) ### Does this PR affect documentation (docs) or should it be mentioned in the release notes? (I'm not sure if it's necessary) * Fix the issue that when restoring partial of backed up raw kv data, TiKV may write out-of-range keys. ### Does this PR affect `tidb-ansible`? ### Refer to a related PR or issue link (optional) - [x] kvproto pingcap/kvproto#581 - [ ] Corresponding PR of BR ### Release note * No release note
gengliqi
pushed a commit
to gengliqi/tikv
that referenced
this pull request
Feb 20, 2021
…ive (tikv#7196) (tikv#9583) cherry-pick tikv#7196 to release-4.0 --- <!-- Thank you for contributing to TiKV! If you haven't already, please read TiKV's [CONTRIBUTING](https://github.com/tikv/tikv/blob/master/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. --> ### What have you changed? Partially fixes tikv#7163 , but it still doesn't work for restoring plain transactional kv (without TiDB). This PR adds is_raw_kv field to DownloadRequest to distinguish rawkv restore requests, and adds end_key_exclusive field to SstMeta so that TiKV knows whether the endkey need to be included.l ### What is the type of the changes? - Bugfix (a change which fixes an issue) ### How is the PR tested? - Unit test - Manual test (add detailed scripts or steps below) ### Does this PR affect documentation (docs) or should it be mentioned in the release notes? (I'm not sure if it's necessary) * Fix the issue that when restoring partial of backed up raw kv data, TiKV may write out-of-range keys. ### Does this PR affect `tidb-ansible`? ### Refer to a related PR or issue link (optional) - [x] kvproto pingcap/kvproto#581 - [ ] Corresponding PR of BR ### Release note * No release note
daimashusheng
pushed a commit
to daimashusheng/kvproto
that referenced
this pull request
Sep 2, 2021
…Kv (pingcap#581) * Add end_key_exclusive field to SSTMeta * Add is_raw_kv field to download request * Revert changes of unrelated go files Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> * build Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tikv/tikv#7163