Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: update parser to support GRANT CREATE TABLESPACE syntax #1048

Merged
merged 7 commits into from
Sep 28, 2020
Merged

*: update parser to support GRANT CREATE TABLESPACE syntax #1048

merged 7 commits into from
Sep 28, 2020

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Sep 16, 2020 •
edited
Loading

NOTE: pingcap/parser with pingcap/parser@a60a80d can't works well with pingcap/tidb (at least to the latest of 2020/09/16 with pingcap/tidb@205c401):
- [privilege:8049]mysql.user ("[privilege:8049]mysql.user") reported in session.BootstrapSession.

What problem does this PR solve?

fix #684

What is changed and how it works?

  • update pingcap/parser (then we also need to update pingcap/tidb and pingcap/tidb-tools because errors code has been updated)

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/WIP This PR is still work in progress type/bug-fix Bug fix dependencies Pull requests that update a dependency file labels Sep 16, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Sep 16, 2020
@csuzhangxc csuzhangxc changed the title *: update parse to support GRANT CREATE TABLESPACE syntax *: update parser to support GRANT CREATE TABLESPACE syntax Sep 16, 2020
@csuzhangxc csuzhangxc added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Sep 28, 2020
@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Sep 28, 2020
GMHDBJD
GMHDBJD approved these changes Sep 28, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 28, 2020
@csuzhangxc csuzhangxc merged commit 84b12c5 into pingcap:master Sep 28, 2020
@csuzhangxc csuzhangxc deleted the update-parser branch September 28, 2020 06:20
@csuzhangxc csuzhangxc added the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label Sep 28, 2020
@csuzhangxc
Copy link
Member Author

/run-cherry-picker

@ti-srebot
Copy link

cherry pick to release-2.0 failed

@ti-srebot
Copy link

cherry pick to release-2.0 failed

csuzhangxc added a commit to csuzhangxc/dm that referenced this pull request Sep 28, 2020
@csuzhangxc
*: update parser to support GRANT CREATE TABLESPACE syntax (pingcap…
b53f7b1 
…#1048)
@csuzhangxc csuzhangxc mentioned this pull request Sep 28, 2020
Merged
csuzhangxc added a commit that referenced this pull request Sep 28, 2020
@csuzhangxc
*: update parser to support GRANT CREATE TABLESPACE syntax (#1048) (#…
d6b93ff 
…1113)
@csuzhangxc csuzhangxc added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Sep 30, 2020
@lance6716 lance6716 added the needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 label Oct 27, 2020
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Oct 27, 2020
@csuzhangxc @ti-srebot
cherry pick pingcap#1048 to release-1.0
670ff16 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@lance6716 lance6716 mentioned this pull request Oct 27, 2020
Merged
@ti-srebot ti-srebot mentioned this pull request Oct 27, 2020
Closed
@ti-srebot
Copy link

cherry pick to release-1.0 in PR #1225

@ti-srebot ti-srebot added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Oct 27, 2020
@lance6716 lance6716 mentioned this pull request Oct 27, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked dependencies Pull requests that update a dependency file priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

parser can't parse GRANT statement with "CREATE TABLESPACE"
4 participants
@csuzhangxc @lance6716 @ti-srebot @GMHDBJD