Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: update parser to support GRANT CREATE TABLESPACE syntax (#1048) #1113

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

csuzhangxc
Copy link
Member

cherry-pick #1048 manually.


NOTE: pingcap/parser with pingcap/parser@a60a80d can't works well with pingcap/tidb (at least to the latest of 2020/09/16 with pingcap/tidb@205c401):
- [privilege:8049]mysql.user ("[privilege:8049]mysql.user") reported in session.BootstrapSession.


What problem does this PR solve?

fix #684

What is changed and how it works?

  • update pingcap/parser (then we also need to update pingcap/tidb and pingcap/tidb-tools because errors code has been updated)

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@csuzhangxc csuzhangxc added dependencies Pull requests that update a dependency file priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Sep 28, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Sep 28, 2020
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 28, 2020
@csuzhangxc csuzhangxc merged commit d6b93ff into pingcap:release-2.0 Sep 28, 2020
@csuzhangxc csuzhangxc deleted the cp-1048 branch September 28, 2020 07:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants