Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

worker: sync master's endpoint peroidcally #1139

Merged
merged 13 commits into from
Oct 16, 2020
Merged

worker: sync master's endpoint peroidcally #1139

merged 13 commits into from
Oct 16, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

close #1110, part of #1127

What is changed and how it works?

use MemberList and GetClientURLs to get all master's endpoint

Check List

Tests

  • Integration test
  • Manual test
    check DEBUG message in log

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@lance6716
Copy link
Collaborator Author

BTW, what's the recommended version upgrade action, need modify test case. join new master and kill old?

@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix labels Oct 12, 2020
csuzhangxc
csuzhangxc reviewed Oct 12, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

dm/worker/server.go Outdated Show resolved Hide resolved
dm/worker/server.go Outdated Show resolved Hide resolved
@lance6716
Copy link
Collaborator Author

/run-all-tests

csuzhangxc
csuzhangxc reviewed Oct 13, 2020
View reviewed changes
dm/worker/server.go Outdated Show resolved Hide resolved
dm/worker/server.go Outdated Show resolved Hide resolved
csuzhangxc
csuzhangxc reviewed Oct 14, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dm/worker/server.go Outdated Show resolved Hide resolved
@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Oct 14, 2020
@lance6716 @csuzhangxc
Update dm/worker/server.go
c54755d 
Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Oct 14, 2020
lichunzhu
lichunzhu approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 merged commit a7caa37 into pingcap:master Oct 16, 2020
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Oct 16, 2020
@lance6716 @ti-srebot
cherry pick pingcap#1139 to release-2.0
826bd91 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 16, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1180

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Oct 16, 2020
csuzhangxc pushed a commit that referenced this pull request Oct 17, 2020
@ti-srebot @lance6716
worker: sync master's endpoint peroidcally (#1139)
aea4661 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: lance6716 <lance6716@gmail.com>
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

worker offline after kill master
4 participants
@lance6716 @ti-srebot @csuzhangxc @lichunzhu