Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

loader: support ANSI_QUOTES when sharing rename #1309

Merged
merged 4 commits into from
Nov 27, 2020
Merged

loader: support ANSI_QUOTES when sharing rename #1309

merged 4 commits into from
Nov 27, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

original code use backquoted scham/table names to do string replace , not supporting upstream has ANSI_QUOTES SQL mode.

What is changed and how it works?

switch to another quote

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@lance6716
Copy link
Collaborator Author

lance6716 commented Nov 27, 2020 •
edited
Loading

sync_diff_inspector will enter deadloop on my local Mac, so CI may not pass

printing many times

[2020/11/27 11:17:51.708 +08:00] [INFO] [checkpoint.go:276] ["summary info"] [instance_id=target] [schema=db_target] [table=t_target] ["chunk num"=4] ["success num"=2] ["failed num"=0] ["ignore num"=0]

@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Nov 27, 2020
@lance6716 lance6716 added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix labels Nov 27, 2020
@lance6716 lance6716 mentioned this pull request Nov 27, 2020
Open
GMHDBJD
GMHDBJD reviewed Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 added the status/LGT1 One reviewer already commented LGTM label Nov 27, 2020
lichunzhu
lichunzhu approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 merged commit 9b83088 into pingcap:master Nov 27, 2020
@lance6716 lance6716 deleted the ansi-quotes-rename branch November 27, 2020 09:49
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Nov 27, 2020
@lance6716 @ti-srebot
cherry pick pingcap#1309 to release-2.0
54ee405 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 27, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1314

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Nov 27, 2020
csuzhangxc pushed a commit that referenced this pull request Nov 27, 2020
@ti-srebot @lance6716
loader: support ANSI_QUOTES when sharing rename (#1309) (#1314)
7e25db1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 mentioned this pull request Mar 10, 2021
Merged
@ti-srebot ti-srebot mentioned this pull request Mar 10, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @ti-srebot @lichunzhu @GMHDBJD