Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

loader: support ANSI_QUOTES when sharing rename (#1309) #1314

Merged
merged 3 commits into from
Nov 27, 2020
Merged

loader: support ANSI_QUOTES when sharing rename (#1309) #1314

merged 3 commits into from
Nov 27, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1309 to release-2.0

What problem does this PR solve?

original code use backquoted scham/table names to do string replace , not supporting upstream has ANSI_QUOTES SQL mode.

What is changed and how it works?

switch to another quote

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@lance6716 @ti-srebot
cherry pick pingcap#1309 to release-2.0
54ee405 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 27, 2020
Merged
@ti-srebot ti-srebot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) first-time-contributor labels Nov 27, 2020
GMHDBJD
GMHDBJD reviewed Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Nov 27, 2020
csuzhangxc
csuzhangxc approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added this to the v2.0.1 milestone Nov 27, 2020
@csuzhangxc csuzhangxc merged commit 7e25db1 into pingcap:release-2.0 Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
first-time-contributor needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @csuzhangxc @GMHDBJD @lance6716