This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
syncer: update active relay log at fake rotate event #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
added
the
needs-cherry-pick-release-2.0
lance6716
added
the
needs-update-release-note
lance6716
changed the title
lance6716
force-pushed
the
update-active-relay
branch
from
be2e7af to
6934fc2
Compare
lichunzhu
reviewed
Feb 24, 2021
this test aims covering a use case of only synchronizing dml, which is specified in release testing doc. |
ti-srebot
pushed a commit
to ti-srebot/dm
that referenced
this pull request
Mar 1, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-2.0 in PR #1468 |
ti-srebot
added
already-cherry-pick-2.0
lance6716
pushed a commit
that referenced
this pull request
Mar 1, 2021
lance6716
removed
the
needs-update-release-note
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
in #1393, we support only specify GTID with no binlog filename, so we can't update active relay log filename at init time. Although active relay log will be updated when after
checkpoint-flush-intervalseconds and receiving an event, for the firstcheckpoint-flush-intervalseconds, purge-relay will fail because of no active relay log, which may confuse user.What is changed and how it works?
when only specify GTID with no binlog filename, use fake rotate event to update active relay log.
also, add a integration test to make sure active relay log is forwarded when there's only DML
Check List
Tests
Code changes
Side effects
Related changes