This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
syncer: update active relay log at fake rotate event (#1448) #1468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1448 to release-2.0
You can switch your code base to this Pull Request by using git-extras:
# In dm repo: git pr https://github.com/pingcap/dm/pull/1468
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
in #1393, we support only specify GTID with no binlog filename, so we can't update active relay log filename at init time. Although active relay log will be updated when after
checkpoint-flush-interval
seconds and receiving an event, for the firstcheckpoint-flush-interval
seconds, purge-relay will fail because of no active relay log, which may confuse user.What is changed and how it works?
when only specify GTID with no binlog filename, use fake rotate event to update active relay log.
also, add a integration test to make sure active relay log is forwarded when there's only DML
Check List
Tests
Code changes
Side effects
Related changes